Skip to content

Reject subtly out-of-order smoother records#4390

Draft
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/reject-out-of-order-smoother-records-20260714
Draft

Reject subtly out-of-order smoother records#4390
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/reject-out-of-order-smoother-records-20260714

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • require record timestamps to be genuinely nondecreasing before RTS or fixed-lag smoothing
  • add a regression for a one-ULP timestamp inversion

Bug

_record_arrays() allowed decreases up to 1e-9 seconds. Fixed-lag smoothing subsequently calls numpy.searchsorted(times, ...), which requires a sorted input array. A tiny accepted inversion could therefore select the wrong fixed-lag endpoint and smooth a record using a chronologically earlier record that happened to appear later in the sequence.

Fix

Reject every negative adjacent timestamp difference while continuing to allow equal timestamps.

Validation

  • added test_fixed_lag_rejects_subtly_decreasing_timestamps
  • branch diff is limited to the one-line validation change and the focused regression

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 25.05s
✅ JSON prettier 7 0 0 0 1.24s
✅ JSON v8r 7 0 0 3.5s
✅ MARKDOWN markdownlint 68 0 0 0 1.99s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.56s
✅ PYTHON black 1490 182 0 0 93.56s
✅ PYTHON isort 1490 327 0 0 2.6s
✅ REPOSITORY betterleaks yes no no 1.62s
✅ REPOSITORY checkov yes no no 55.85s
✅ REPOSITORY gitleaks yes no no 16.23s
✅ REPOSITORY git_diff yes no no 0.31s
✅ REPOSITORY secretlint yes no no 55.74s
✅ REPOSITORY syft yes no no 4.81s
✅ REPOSITORY trivy-sbom yes no no 7.59s
✅ REPOSITORY trufflehog yes no no 33.34s
✅ YAML prettier 11 0 0 0 0.73s
✅ YAML v8r 11 0 0 11.08s
✅ YAML yamllint 11 0 0 0.58s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant