Reject wrong-sized MEM-RBPF control inputs#4437
Open
FlorianPfaff wants to merge 5 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
MEMRBPFTracker.predict_linear()control inputs against the kinematic-state shapeRoot cause
predict_linear()previously convertedinputsonly at the point of addition. NumPy therefore accepted shapes such as(1,)and broadcast the single value across every component of a four-dimensional kinematic state, silently applying an unintended control.Fix
Convert and validate
inputsat the start of prediction. A non-Nonecontrol must have exactly the same shape askinematic_state; otherwise the method raisesValueErrorbefore changing the system matrix, process noise, kinematic state, covariance, or conditional extent state.Validation
fec88b01d0c9be7486b13bc3f3710301d4c5b9bdbyte-for-bytepython -m py_compilepasses for the modified module and regression test