Stabilize Merwe sigma-point scaling#4447
Open
FlorianPfaff wants to merge 4 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
MerweScaledSigmaPointscomputed the positive sigma-point scale asn + lambdaafter first evaluatinglambda = alpha**2 * (n + kappa) - n. For sufficiently small but representable positivealpha, subtractingnroundslambdato exactly-n; addingnback then yields zero. Construction consequently raisesZeroDivisionError, and sigma-point generation would use a zero Cholesky scale.For example,
n=2,kappa=0, andalpha=1e-10have the valid direct scale2e-20, but the previous cancellation-prone reconstruction produces0.0.Fix
alpha * alpha * (n + kappa)directlyValueErrorValidation
ZeroDivisionErroranalytically foralpha=1e-102 passedmain, 0 behind, with 10 implementation-line changes and one focused test fileFull repository CI should run on this pull request.