Stabilize SO(3) chordal weight normalization#4448
Open
FlorianPfaff wants to merge 2 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
SO3ChordalMeanSmoother._normalize_weight_vector()summed finite nonnegative weights at their original scale. For weights near the active floating-point maximum, the sum could overflow to infinity. Dividing by that total then collapsed every normalized weight to zero, so the projected chordal mean could become an unrelated rotation.For example, weights proportional to
3:1at thefloat64limit produced the identity rotation instead of the same weighted mean as ordinary[3.0, 1.0]weights.The same risk applied when finite sample and kernel weights were multiplied during local smoothing.
Fix
Validation
[0.75, 0.25]for the extreme finite3:1case[3.0, 1.0]weightsmain, 0 behind, and changes only the smoother plus the focused regressionFull repository CI is requested by this pull request.