Skip to content

refactor(review): converge strict review entry#1488

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/review-convergence-pr1
Jul 9, 2026
Merged

refactor(review): converge strict review entry#1488
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/review-convergence-pr1

Conversation

@limityan

@limityan limityan commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add Review / Verify implementation guardrails for the next two large PRs, keeping PR1 focused on visible Review convergence and PR2 reserved for dynamic Review/Verify decisions.
  • Reframe DeepReview as the compatibility runtime behind Review: Strict: /review strict is the canonical typed strict-review command, while /DeepReview and /deepreview remain compatibility aliases.
  • Remove ReviewTeam as a user-facing product surface from Agents/settings discovery, keeping reviewer-set details internal to strict Review.
  • Keep strict Review as a background child-session run by default: launch inserts a parent-session summary card, and the auxiliary pane opens only when the user chooses to inspect details.
  • Keep strict Review consent focused on the current run: no hidden project-strategy persistence from the confirmation dialog; users see prompt cost, approximate input-token range, runtime tradeoff, selected strategy, and review-scope notes.
  • Map review sources to user-facing coverage labels in reports, exports, tool cards, and interruption diagnostics; unknown Review* remediation sources are no longer silently treated as read-only reviewer coverage.

Compatibility and Scope

  • Historical deep_review session kind, DeepReview agent type, launch manifest fields, queue behavior, persistence, and old /DeepReview typed command compatibility remain available for migration and old session recovery.
  • /review deep is intentionally not accepted; the new strict path is /review strict.
  • No dynamic review-depth selector, Verify gate, runtime scheduler rewrite, PR Review executor, or sdlc-harness orchestration engine is introduced in this PR.
  • PR Review remains a consumer/projection boundary in the docs; Verify remains exploration-only for PR1.
  • Rebased onto gcwing/main at fe66646ca.

Review

  • Independent architecture subagent review found desktop-main drift, command alias ambiguity, untracked source-label mapping, and an over-strong auxiliary-pane doc claim; all were fixed and rechecked.
  • Independent product-design subagent review found consent cost visibility gaps, reviewer/source leakage, default auxiliary-pane launch, and role/reviewer wording in settings; all Important items were fixed and rechecked.
  • A second architecture/product adversarial pass found remaining user-visible downgrade wording, hidden Review agent fallback leakage, hidden consent strategy persistence, export/report manifest drift, and broad Review* read-only classification; all were fixed and rechecked.
  • Final local review confirms user-facing copy now presents automatic scope selection instead of downgrade, the confirmation dialog does not mutate settings, read-only review and remediation are separated, and token/cost prompts remain bounded to strict Review entry points.

Verification

Check Result
pnpm --dir src/web-ui run test:run ... focused Review/strict Review suite Pass, 14 files / 133 tests
pnpm run type-check:web Pass
pnpm run i18n:contract:test Pass, 37 tests
pnpm run i18n:audit Pass, 0 warnings
git diff --check gcwing/main...HEAD Pass
cargo check -p bitfun-desktop Not rerun in this update; prior attempt was blocked by external/local preconditions: oxc_transformer 0.138.0 uses unstable if let guards for this Rust toolchain, and the Tauri build script reports missing src/mobile-web/dist.

@limityan limityan force-pushed the yanzhn/review-convergence-pr1 branch 2 times, most recently from 16771c8 to d8a5c30 Compare July 9, 2026 13:29
@limityan limityan force-pushed the yanzhn/review-convergence-pr1 branch from d8a5c30 to 3c78180 Compare July 9, 2026 14:02
@limityan limityan merged commit f072467 into GCWing:main Jul 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant