Add Game Experience overlay loadout preset#658
Open
gvinals wants to merge 1 commit into
Open
Conversation
Introduce a fourth default loadout (preset-1.json) and reorder shipped presets so indices 0-3 match UI order: Basic, Game Experience, GPU Focus, Power/Temp.
gvinals
force-pushed
the
gvinals/game_experience_preset
branch
from
77818ab to
fee8a0b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new default “Game Experience” overlay loadout preset and updates the UI/logic so the built-in preset indices (0–3) align with the preset selector order.
Changes:
- Added a 4th built-in preset slot (index 3) and updated preset cycling to include it.
- Updated the preset selector UI to include “Game Experience” as a new default option.
- Reworked the shipped preset JSON files and added a new
preset-3.jsonloadout.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| IntelPresentMon/PMInstaller/PresentMon.wxs | Ships an additional preset file (preset-3.json) in the installer. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/views/MainView.vue | Adds the “Game Experience” preset button in the preset toggle group. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/core/preferences.ts | Adds Preset.Slot4 = 3 to represent the new built-in preset. |
| IntelPresentMon/AppCef/ipm-ui-vue/src/App.vue | Extends preset hotkey cycling logic to cycle through 0–3. |
| IntelPresentMon/AppCef/ipm-ui-vue/presets/preset-1.json | Updates the loadout content for preset index 1 (now “Game Experience”). |
| IntelPresentMon/AppCef/ipm-ui-vue/presets/preset-2.json | Updates the loadout content for preset index 2 (“GPU Focus”). |
| IntelPresentMon/AppCef/ipm-ui-vue/presets/preset-3.json | Adds the new preset index 3 loadout (“Power/Temp”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
10
to
16
| export enum Preset { | ||
| Slot1 = 0, | ||
| Slot2 = 1, | ||
| Slot3 = 2, | ||
| Slot4 = 3, | ||
| Custom = 1000, | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Discussed in tech sync. Won't bother with that.
Comment on lines
+512
to
+520
| <Component | ||
| Id="pm_app_preset_3" | ||
| Guid="A1C2E3F4-5B6D-4789-A012-3456789ABCDE"> | ||
| <File | ||
| Id="pm_app_preset_3" | ||
| Name="preset-3.json" | ||
| Source="$(var.PresentMon.TargetDir)Presets\preset-3.json" | ||
| KeyPath="yes"> | ||
| </File> |
Collaborator
Author
There was a problem hiding this comment.
Same as above. The preset name being tied to the order in which they are shown is unfortunate but we don't want to change that here...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a fourth default loadout (preset-1.json) and reorder shipped presets so indices 0–3 match UI order: Basic, Game Experience, GPU Focus, Power/Temp.