fix: named args in partial work in nested #each (issue #455)#630
Merged
Conversation
…ch (issue #455) Verifies that {{> myPartial arg1=value1 arg2=value2}} works correctly inside a nested {{#each}} loop without throwing ArgumentOutOfRangeException. The existing #422 fix in BindingContext.PopulateHash already covers this case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
Summary
{{> myPartial arg1=value1 arg2=value2}}) inside a nested{{#each}}loop were reported to throwArgumentOutOfRangeException.BindingContext.PopulateHashguarding againstObjectDescriptor.Empty) already covers the nested#eachcase as well.source/Handlebars.Test/Issues/Issue455Tests.csto explicitly document and lock in this behavior.Test plan
Issue455_NamedArgsInPartialInsideNestedEachadded toIssue455Tests.csPartial hash parameters no longer throw
ArgumentOutOfRangeExceptionwhen used inside a nested#eachloop.🤖 Generated with Claude Code