Feat: Select welcome-select windows#540
Conversation
JavierRibaldelRio
added
Frontend
javascript
|
When I first open testing-view, then go back and open testing-view again application crashes 
|
|
You could consider adding a test that will verify this behavior in E2E and modifying e2e tests so they pass |
| // Start services and only then load the selected view. | ||
| if (view === "testing-view" || view === "flashing-view") { | ||
| await startServices(screenWidth, screenHeight, view); | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); |
There was a problem hiding this comment.
I'm not sure you need this timeout since you use async functions that are awaited
There was a problem hiding this comment.
Even though startServices is awaited the testing view tries to connect to the backend before it has opened the websockets port. This extra delay at backend is caused by ADJ-Validator.
Without it does not work properly.
There was a problem hiding this comment.
At least it's supposed to connect only after the 'backend is ready' message arrives, but i'm not sure about details
…d-start-python-api-script fix: build python deps and binaries
…com/Hyperloop-UPV/software into control-station/multiple-select-app Upadte local branch to avoid conflict at develop
Thats because is does not exists. |
|
It seems I have messed up a little bit with GitHub, sorry
I'll look at it. ;) |
i think you misread my message |
3 participants
Uh oh!
There was an error while loading. Please reload this page.