Skip to content

[FIX] Auth: Prevent resetting mail options for ECS users #11734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mjansenDatabay wants to merge 1 commit into
base: release_10
Choose a base branch
from
+0 −17
Draft

[FIX] Auth: Prevent resetting mail options for ECS users #11734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions components/ILIAS/WebServices/ECS/classes/class.ilAuthProviderECS.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,6 @@ protected function createUser(ilECSUser $user): string

$this->getLogger()->info('Created new remote user with usr_id: ' . $user->getImportId());

// Send Mail
#$this->sendNotification($userObj);
$this->resetMailOptions($userObj->getId());

return $userObj->getLogin();
}

Expand Down Expand Up @@ -436,20 +432,7 @@ protected function updateUser(ilECSUser $user, int $a_local_user_id): string
);
}

$this->resetMailOptions($a_local_user_id);

$this->getLogger()->debug('Finished update of remote user with usr_id: ' . $user->getImportId());
return $user_obj->getLogin();
}

/**
* Reset mail options to "local only"
*
*/
protected function resetMailOptions(int $a_usr_id): void
{
$options = new ilMailOptions($a_usr_id);
$options->setIncomingType(ilMailOptions::INCOMING_LOCAL);
$options->updateOptions();
}
}
Loading