Skip to content

[IMPROVEMENT] Cron: Remove client_id argument from CLI command #11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjansenDatabay wants to merge 1 commit into
base: trunk
Choose a base branch
from
+0 −6
Open

[IMPROVEMENT] Cron: Remove client_id argument from CLI command #11735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions components/ILIAS/Cron/src/CLI/Commands/RunActiveJobsCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,13 @@ protected function configure(): void
$this->setDescription('Runs cron jobs depending on the respective schedule');

$this->addArgument('user', InputArgument::REQUIRED, 'The ILIAS user the script is executed with');
$this->addArgument('client_id', InputArgument::REQUIRED, 'The ILIAS client_id');
}

protected function execute(InputInterface $input, OutputInterface $output): int
{
$this->style = new SymfonyStyle($input, $output);

$cron = new \ILIAS\Cron\CLI\StartUp(
$input->getArgument('client_id'),
$input->getArgument('user')
);

Expand Down
4 changes: 0 additions & 4 deletions components/ILIAS/Cron/src/CLI/StartUp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,12 @@ class StartUp
private bool $is_authenticated = false;

public function __construct(
private readonly string $client,
private readonly string $username,
?\ilAuthSession $authSession = null
) {
/** @noRector */
\ilContext::init(\ilContext::CONTEXT_CRON);

// TODO @see mantis 20371: To get rid of this, the authentication service has to provide a mechanism to pass the client_id
$_GET['client_id'] = $this->client;

require_once __DIR__ . '/../../../../../artifacts/bootstrap_default.php';
entry_point('ILIAS Legacy Initialisation Adapter');

Expand Down
Loading