[SDK-415] Fix for notification icon#1068
Merged
franco-zalamena-iterable merged 5 commits intoJun 25, 2026
Merged
Conversation
rtlsilva
approved these changes
Jun 24, 2026
…ification-icon-fallback
The 3.9.0 release (#1069) shipped without this PR's notification-icon fallback feature, so the entry belongs under Unreleased, not 3.9.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sumeruchat
approved these changes
Jun 25, 2026
sumeruchat
left a comment
sumeruchat
left a comment
Contributor
There was a problem hiding this comment.
Approving. Good call folding the worker's duplicate getSmallIconId into the shared getIconId, so the foreground-service and normal push notifications now resolve the icon identically.
Two non-blocking notes:
- The new chain silently adopts @drawable/notification_icon or ic_notification before the launcher icon. Intentional and net-positive (fixes the white-blob), but worth making the CHANGELOG line explicit that those conventionally-named drawables can now be picked up automatically.
- The new tests cover the new sources well, but not the setNotificationIcon()/SharedPreferences source, source #2 winning over Firebase/convention, or notification_icon winning over ic_notification. Worth adding if you want full ordering coverage.
franco-zalamena-iterable
deleted the
feature/SDK-415-notification-icon-fallback
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
This pr fixes the icon fallback going to the default icon on low resolutions in some edge cases
master.webm
icon_fallback.webm