LaboratoryController: Use java DOM API instead of StringBuilder#289
Open
labkey-alan wants to merge 1 commit into
Open
LaboratoryController: Use java DOM API instead of StringBuilder#289labkey-alan wants to merge 1 commit into
labkey-alan wants to merge 1 commit into
Conversation
labkey-martyp
approved these changes
Jun 22, 2026
bbimber
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Using StringBuilder to manually build up HTML is error prone and unsafe. Updating usages to use the java DOM API so all HTML is properly escaped and potential XSS issues are mitigated.
Related Pull Requests
Changes