Skip to content

GH Issue 594: Update messaging related to parent samples/sources not found during import #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-susanh wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

GH Issue 594: Update messaging related to parent samples/sources not found during import #3071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf6c9bf
GH Issue 594: Update messaging related to parent samples/sources not …
labkey-susanh Jun 23, 2026
d94340d
Merge remote-tracking branch 'origin/develop' into fb_importErrorMess…
labkey-susanh Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/org/labkey/test/tests/SampleTypeLineageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,9 +797,9 @@ public void testLineageWithInvalidValue() throws IOException, CommandException
fail("Expect CommandException when inserting bogus lineage");
}catch (CommandException successMaybe)
{
assertTrue("expect bad lineage to produce error containing [Sample 'BOGUS' not found in Sample Type 'badLineageTest'.];\n" +
assertTrue("expect bad lineage to produce error containing [Parent sample 'BOGUS' from Sample Type 'badLineageTest' not found in the current context.];\n" +
"instead got: [" + successMaybe.getMessage() + "]",
successMaybe.getMessage().contains("Sample 'BOGUS' not found in Sample Type 'badLineageTest'."));
successMaybe.getMessage().contains("Parent sample 'BOGUS' from Sample Type 'badLineageTest' not found in the current context."));
}
}

Expand All @@ -826,9 +826,9 @@ public void testLineageWithInvalidParentColumnValue() throws IOException, Comman
fail("Expect CommandException when inserting bogus lineage");
}catch (CommandException successMaybe) // success looks like a CommandException with the expected message
{
assertTrue("expect bad lineage to produce error containing [Sample 'BOGUS' not found in Sample Type 'badParentLineage'.];\n" +
assertTrue("expect bad lineage to produce error containing [Parent sample 'BOGUS' from Sample Type 'badParentLineage' not found in the current context.];\n" +
"instead got: [" + successMaybe.getMessage() + "]",
successMaybe.getMessage().contains("Sample 'BOGUS' not found in Sample Type 'badParentLineage'."));
successMaybe.getMessage().contains("Parent sample 'BOGUS' from Sample Type 'badParentLineage' not found in the current context."));
}

// clean up on success
Expand Down