avoid repeated sums in mesh plan#1034
Open
Debraheem wants to merge 1 commit into
Open
Conversation
Member
Author
|
I change the dq_sum name to xq_sum. I would be fine not changing it, whatever is less confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, MESA does a sum from 0-> k_new in dq on every iteration of the mesh plan do loop using the fortran instrinsic
sum()function:This branch alters the dq sum inside mesh plan to one that is cumulative, hence changing the speed of this algorithm for the sum from O(n^2) to O(n) in time.
I did some timing tests below, where i specifically look at the time spent inside the mesh routines, as opposed to the global time the runs took. Generally i noticed a ~ 1% or less increase in total performance, but I can imagine anytime the mesh is changes a lot, this minor improvement will reduce the time spent remeshing.
I don't believe this change needs a changelog entry.