Skip to content

feat: new file limits#1077

Merged
coodos merged 1 commit into
mainfrom
feat/raise-file-size-limit
Jul 8, 2026
Merged

feat: new file limits#1077
coodos merged 1 commit into
mainfrom
feat/raise-file-size-limit

Conversation

@coodos

@coodos coodos commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features

    • Increased file upload limits across the app, allowing uploads up to 250 MB.
    • Raised server request body limits to better support large file submissions.
  • Bug Fixes

    • Updated oversized-file validation messages to reflect the new upload limit.
    • Kept client and server upload checks aligned to reduce rejected uploads for valid large files.

@coodos coodos merged commit 7ca1f66 into main Jul 8, 2026
5 of 6 checks passed
@coodos coodos deleted the feat/raise-file-size-limit branch July 8, 2026 19:09
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a1222c65-7575-4e17-9cff-6ba922486566

📥 Commits

Reviewing files that changed from the base of the PR and between 99d053e and 93ae70d.

📒 Files selected for processing (6)
  • infrastructure/evault-core/src/core/protocol/graphql-server.ts
  • infrastructure/evault-core/src/index.ts
  • infrastructure/evault-core/src/test-utils/e2e-setup.ts
  • platforms/esigner/api/src/controllers/FileController.ts
  • platforms/esigner/api/src/index.ts
  • platforms/esigner/client/src/lib/stores/files.ts

📝 Walkthrough

Walkthrough

File upload size limits were increased across two services: evault-core's GraphQL upload limit and Fastify bodyLimit went from ~20-50MB to 250-350MB (with matching e2e test config), and esigner's controller, Express body parser, and client store limits were raised from 20MB to 250MB.

Changes

Upload size limit increases

Layer / File(s) Summary
evault-core GraphQL and server body limits
infrastructure/evault-core/src/core/protocol/graphql-server.ts, infrastructure/evault-core/src/index.ts, infrastructure/evault-core/src/test-utils/e2e-setup.ts
GraphQL uploadFile max size raised from 50MB to 250MB with a dynamically computed error message; Fastify bodyLimit raised from ~20MB to 350MB with documentation on base64/JSON overhead and dependency on MAX_FILE_BYTES; e2e test server bodyLimit matched to 350MB.
esigner API and client size limits
platforms/esigner/api/src/controllers/FileController.ts, platforms/esigner/api/src/index.ts, platforms/esigner/client/src/lib/stores/files.ts
MAX_FILE_SIZE in the file controller raised from 20MB to 250MB affecting multer's fileSize limit; Express json/urlencoded body limits raised from 20mb to 250mb; client-side MAX_FILE_SIZE raised to 250MB, affecting pre-upload validation and FileSizeError messaging.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/raise-file-size-limit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant