Skip to content

fix: fixed the race condition when opening app through deeplink.#1078

Open
Sahil2004 wants to merge 1 commit into
mainfrom
fix/biometricDeeplinkColision
Open

fix: fixed the race condition when opening app through deeplink.#1078
Sahil2004 wants to merge 1 commit into
mainfrom
fix/biometricDeeplinkColision

Conversation

@Sahil2004

@Sahil2004 Sahil2004 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description of change

Fixed the race condition when loggin in app through deeplink.

Issue Number

Closes #1048

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

Manually.

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes
    • Improved the splash screen flow to avoid overlapping authentication prompts when a pending deep link is present.
    • Added a direct redirect to the login screen for users arriving through a deep link, resulting in a smoother and more reliable sign-in experience.

@Sahil2004 Sahil2004 self-assigned this Jul 9, 2026
@Sahil2004 Sahil2004 requested a review from coodos as a code owner July 9, 2026 04:46
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2c38f5b8-d9c8-4426-8ef5-dae326641f51

📥 Commits

Reviewing files that changed from the base of the PR and between 388ccb2 and 3a90e64.

📒 Files selected for processing (1)
  • infrastructure/eid-wallet/src/routes/+page.svelte

📝 Walkthrough

Walkthrough

The splash route now checks for a pendingDeepLink value in sessionStorage before running its biometric authentication flow. If present, it redirects the user to /login and exits early, avoiding conflict with the deep-link handling already performed elsewhere.

Changes

Splash Route Deep-Link Redirect

Layer / File(s) Summary
Early deep-link guard
infrastructure/eid-wallet/src/routes/+page.svelte
Adds a check for sessionStorage.pendingDeepLink on the splash page that redirects to /login and skips the splash biometric prompt when a pending deep link exists.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: coodos

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the deeplink race-condition fix and matches the change set.
Description check ✅ Passed The description includes the change summary, issue number, type, testing, and checklist sections.
Linked Issues check ✅ Passed The change redirects deeplink cases to the login flow, which aligns with preventing biometric auth from blocking third-party consent [#1048].
Out of Scope Changes check ✅ Passed The PR appears narrowly scoped to a single splash-route logic change with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/biometricDeeplinkColision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Biometric login blocks third-party consent acceptance when app is not running in background

1 participant