Conversation
Added - Governance test project for request lifecycle and version resolution behavior - Segregated characterization tests for lifecycle atomicity, store overwrite semantics, and resolution persistence - Shared test support for seeded requests and stale-snapshot stores Result Governance runtime risks now have executable characterization coverage so concurrency, store-contract, and resolution-persistence behavior can be validated before changing the execution model.
# Conflicts: # Tests/ModularityKit.Mutator.Governance.Tests/Lifecycle/MutationRequestLifecycleAtomicityTests.cs # Tests/ModularityKit.Mutator.Governance.Tests/Lifecycle/MutationRequestStoreContractTests.cs # Tests/ModularityKit.Mutator.Governance.Tests/Resolution/MutationRequestVersionResolutionPersistenceTests.cs # Tests/ModularityKit.Mutator.Governance.Tests/TestSupport/StaleSnapshotMutationRequestStore.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optimistic concurrency semantics to governance request storage so lifecycle transitions no longer depend on blind saves.
Added
MutationRequest.Revisionas the governance concurrency guardIMutationRequestStore.Create(...)andTryStore(..., expectedRevision)for explicit create and guarded update pathsMutationRequestAlreadyExistsExceptionfor duplicate request creation attemptsMutationRequestConcurrencyExceptionfor lifecycle transition racesChanged
Result
Governance request storage now exposes explicit create and optimistic concurrency update semantics. Concurrent lifecycle transitions no longer both succeed against the same stale snapshot, and the runtime reports a clear concurrency failure when a guarded transition loses the race.
Testing
dotnet build src/ModularityKit.Mutator.Governance.csproj -c Releasedotnet test Tests/ModularityKit.Mutator.Governance.Tests/ModularityKit.Mutator.Governance.Tests.csproj -c Releasedotnet build ModularityKit.Mutator.slnx -c ReleaseLinked Issues
Checklist