Skip to content

Add KGX release version used#569

Merged
colleenXu merged 8 commits into
2.0from
add-kgx-version
Jul 9, 2026
Merged

Add KGX release version used#569
colleenXu merged 8 commits into
2.0from
add-kgx-version

Conversation

@colleenXu

@colleenXu colleenXu commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

To address #568 based on decisions in today's TRAPI meeting.

TBD discussion needed first:

  • Value: link to KGX storage versioned graph-metadata file (example) or the release-version only? Assigned to @tokebe to ask Adil if there's any issue using the link
  • Field name: could be more general like data_version? But maybe depends on what value is (keep specific if value is version only - needs more descriptive, make general if value is link).

@colleenXu colleenXu changed the base branch from master to 2.0 June 25, 2026 19:48
@colleenXu colleenXu marked this pull request as draft June 25, 2026 19:49
@tokebe

tokebe commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

I would argue we want a generic field name and allow a string value, so non translator-kg resources are still fine.

@tokebe

tokebe commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

From discussion: change field to data_release_version and make the type an object with values of str, minimum properties 1, with the overall field not required (matching the other version fields)

@tokebe tokebe marked this pull request as ready for review July 9, 2026 20:06
@edeutsch edeutsch requested review from MarkDWilliams and tokebe July 9, 2026 20:07
@colleenXu

Copy link
Copy Markdown
Contributor Author

Looks like the spec/example is fine in swagger editor

Screenshot 2026-07-09 at 13 06 43

@edeutsch edeutsch self-requested a review July 9, 2026 20:07
@colleenXu colleenXu merged commit 3271ed3 into 2.0 Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants