Skip to content

BCSS-23624 - feat(cloudwatch): add cloudwatch module#61

Merged
DeepikaDK001 merged 17 commits into
mainfrom
feature/BCSS-23624-terraform-module-Cloudwatch
Jul 3, 2026
Merged

BCSS-23624 - feat(cloudwatch): add cloudwatch module#61
DeepikaDK001 merged 17 commits into
mainfrom
feature/BCSS-23624-terraform-module-Cloudwatch

Conversation

@DeepikaDK001

Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhs-oliverslater nhs-oliverslater changed the title BCSS - 23624 add cloudwatch module BCSS-23624 - feat(cloudwatch): add cloudwatch module Jun 27, 2026
@nhs-oliverslater

Copy link
Copy Markdown
Contributor

I worry that wrapping all the submodules into one single larger module will make things rather bloated and unwieldy - can we discuss this in SU to review and possible submodule these?

@Pira-nhs Pira-nhs self-requested a review July 1, 2026 09:44
Comment thread infrastructure/modules/cloudwatch-log-metric-filter/main.tf Outdated
Comment thread infrastructure/modules/cloudwatch-log-metric-filter/variables.tf
Comment thread infrastructure/modules/cloudwatch-logs/variables.tf Outdated
Comment thread infrastructure/modules/cloudwatch-logs/variables.tf
Comment thread infrastructure/modules/cloudwatch-metric-alarm/variables.tf
@DeepikaDK001 DeepikaDK001 marked this pull request as ready for review July 3, 2026 12:59
@DeepikaDK001 DeepikaDK001 requested review from a team and saliceti as code owners July 3, 2026 12:59
@DeepikaDK001 DeepikaDK001 merged commit 4dda6f8 into main Jul 3, 2026
34 checks passed
@DeepikaDK001 DeepikaDK001 deleted the feature/BCSS-23624-terraform-module-Cloudwatch branch July 3, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants