Swap pv-battery FOM configurations from ptc to ITC#2240
Open
brtietz wants to merge 1 commit into
Open
Conversation
brtietz
added
financial
cpaulgilman
requested changes
Jul 2, 2026
cpaulgilman
left a comment
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
There are some issues here. For example:
PVWatts-Battery / Single Owner has the ITC percentage assigned to Federal Amount instead of Federal Percentage:
Custom Generation-Battery / TPO Host-Developer has ITC percentages set to zero.
I will try to fix these before the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Swap PTC to ITC for batteries
Corresponding branches and PRs:
Develop for other branches
Unit Test Impact:
Updated test_script_ow.lk results for attached defaults changes
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)