API-56 Fixed allowed domains, allow localhost to run for explorer whe…#230
Merged
Conversation
…n being deployed locally and on dev mode
There was a problem hiding this comment.
Pull request overview
Updates the API’s CORS configuration to broaden permitted browser origins, aiming to support Explorer development workflows (including localhost) and add an additional approved site.
Changes:
- Added
https://yanbingchen.siteto the hard-coded CORS allowlist. - Modified localhost CORS handling to allow localhost origins (and added logging on rejection).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
50
| if (localhostRe.test(origin)) return callback(null, true); | ||
| console.error(`CORS rejected origin: ${origin}`); | ||
| return callback(new Error(`CORS: origin ${origin} not allowed`)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-56
Fixed so that explorer developers can access even on dev/localhost modes.
Added yanbing's site.