Skip to content

[18.][ADD] New module geospatial_plot#429

Open
NL66278 wants to merge 1 commit into
OCA:18.0from
Therp:18.0-add-geospatial_plot
Open

[18.][ADD] New module geospatial_plot#429
NL66278 wants to merge 1 commit into
OCA:18.0from
Therp:18.0-add-geospatial_plot

Conversation

@NL66278

@NL66278 NL66278 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

New module allows to define and draw plots on a map and link them to partners.

This PR depends on #422

@legalsylvain

Copy link
Copy Markdown
Contributor

hi @NL66278 Could you take a look on red CI ?

thanks !

@NL66278

NL66278 commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

@legalsylvain The tests is failing because the PR for web_leaflet_draw_lib has not been merged yet. Did you finally get merge rights, or is that also still stalled?

@thomaspaulb

Copy link
Copy Markdown

/ocabot rebase

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@thomaspaulb The rebase process failed, because command git push --force Therp tmp-pr-429:18.0-add-geospatial_plot failed with output:

remote: Permission to Therp/geospatial.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Therp/geospatial/': The requested URL returned error: 403

@thomaspaulb thomaspaulb force-pushed the 18.0-add-geospatial_plot branch from 140992c to c19cca1 Compare January 18, 2026 22:08
@thomaspaulb

Copy link
Copy Markdown

@NL66278 New test failure looks legit: TypeError: ResPartner._compute_land_acreage() missing 1 required positional argument: 'acreage_sqm'

@NL66278 NL66278 force-pushed the 18.0-add-geospatial_plot branch from c19cca1 to 1b8725f Compare January 19, 2026 08:42
New module allows to define and draw plots on a map and link them to partners.
@NL66278 NL66278 force-pushed the 18.0-add-geospatial_plot branch from 1b8725f to 0011af8 Compare January 19, 2026 08:55
@legalsylvain

Copy link
Copy Markdown
Contributor

@NL66278 : what about to have leaflet in the name of the module ? In fact, we could imagine other implementation, based on other librairies. Don't you think ?

@NL66278

NL66278 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

@NL66278 : what about to have leaflet in the name of the module ? In fact, we could imagine other implementation, based on other librairies. Don't you think ?

In this case I would like to keep the name. The use of the leaflet library is very helpful, but still an implementation detail, even though it is unlikely to change in the foreseeable future.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 12, 2026
@legalsylvain

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-429-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@legalsylvain The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_geospatial_plot-18.0.1.0.1-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_geospatial_plot-18.0.1.0.1-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests                                                      

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants