[18.][ADD] New module geospatial_plot#429
Conversation
393310e to
140992c
Compare
|
hi @NL66278 Could you take a look on red CI ? thanks ! |
|
@legalsylvain The tests is failing because the PR for web_leaflet_draw_lib has not been merged yet. Did you finally get merge rights, or is that also still stalled? |
|
/ocabot rebase |
|
@thomaspaulb The rebase process failed, because command |
140992c to
c19cca1
Compare
|
@NL66278 New test failure looks legit: |
c19cca1 to
1b8725f
Compare
New module allows to define and draw plots on a map and link them to partners.
1b8725f to
0011af8
Compare
|
@NL66278 : what about to have leaflet in the name of the module ? In fact, we could imagine other implementation, based on other librairies. Don't you think ? |
In this case I would like to keep the name. The use of the leaflet library is very helpful, but still an implementation detail, even though it is unlikely to change in the foreseeable future. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@legalsylvain The merge process could not be finalized, because command |
New module allows to define and draw plots on a map and link them to partners.
This PR depends on #422