Harden reusable workflow contracts#175
Merged
Merged
Conversation
63d93f9 to
acd0507
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
acd0507 to
7762ae8
Compare
Route release and security work to hosted runners, make hosted CI the safe default, pin every external action by commit SHA, and add an executable caller smoke workflow. Document the immutable v0.2.2 consumer contract pending its verified release.
7762ae8 to
48de71e
Compare
athena-omt
approved these changes
Jul 14, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the reusable workflow contract hardening. The contract now defaults untrusted CI callers to hosted runners, keeps privileged security/release workflows hosted, pins external actions to full SHAs, and adds smoke callers/tests that exercise the reusable entrypoints without publishing artifacts.
Validation run on the refreshed PR head:
- pnpm vitest run test/reusable-workflow-contract.test.ts test/security-workflow.test.ts
- pnpm lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rg-securityandrg-releaseexclusively to GitHub-hosted runnersrg-cidefault while retaining an explicit trustedshell-safe-publiclane with shell-safe Node installationv0.2.2consumer reference and required permissionsGoverning Issue
Refs #117
Issue #117 remains open until this PR and #170 are merged, the verified
v0.2.2GitHub release/tag is published frommain, and the caller smoke is rerun against that public ref. The workflow implementation itself is merge-ready; tagging unreviewed feature-branch code would violate the release contract.Validation
CI=true bash scripts/ci/run-fast-checks.sh(49 files, 275 tests; lint and build passed)pnpm exec vitest run test/reusable-workflow-contract.test.ts test/security-workflow.test.ts test/workflow.test.ts(3 files, 21 tests passed)actionlint -ignore 'label .* is unknown'on all four reusable/caller workflowsgit diff --checkContract Safety
GITHUB_TOKENplus OIDC; no long-lived registry secret is introducedMerge Automation