fix: drop venue-typed source enums; align examples with market_reporting (#4175)#51
Merged
Merged
Conversation
…ing (#4175) Source fields are already free-string typed (no venue enum to loosen); this aligns example/fixture source values with the API switch to market_reporting masked labels (government labels like EIA/opec.org unchanged). Version bumped (patch, unpublished). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe SDK version is bumped from 1.10.1 to 1.10.2. Commodity test fixtures now use ChangesSDK 1.10.2 release update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Part of the SDK-fleet sweep for oilpriceapi-api#4175. The API is switching masked source labels to
market_reporting(government labels likeEIA/opec.orgunchanged). This aligns the Python SDK.Typing
No change needed to loosen — all model
sourcefields are already freestr(models.pylines 197/265/284/371,Field(description=...)). There is no venue enum in this SDK. So nothing breaks when the API starts returningmarket_reporting.Examples/fixtures fixed
tests/unit/test_commodities_resource.py: fixture"source": "ICE"→"source": "market_reporting"(the only venue-as-source value in the repo).README/docs contain no venue-as-source claims (verified).
Version (unpublished)
1.10.1→1.10.2inpyproject.tomlandoilpriceapi/version.pyTest/build
pytestis not installed in the sandbox, so the suite was not run here; the change is a single fixture-value swap (syntax validated, noICEremaining). CI will run the full suite.🤖 Generated with Claude Code
Summary by CodeRabbit
market_reportingas the source label.EIAandopec.org, remain unchanged.