Fix Issue #592: fix Pegasos Kernel SVM implementation#593
Open
Rishi-Jain-27 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue with the solution and the test cases for the Pegasos Kernel SVM implementation.
The first issue was that alphas[i] was being calculated using two different methods at the same time.
The first method multiplies index[j] in the decision_value calculation.
The second method multiplies eta by index[i] in the alphas[i] update if the margin is violated.
Both were implemented. I removed the second method.
The second issue is that the problem description indicates an else to the margin violation condition that says that alphas[i] should be updated regardless, but without adding eta. This was not implemented. I implemented this.