Wire 9 UK Open Banking v4.0.1 AIS/consent endpoints to real data#2864
Closed
hongwei1 wants to merge 1 commit into
Closed
Wire 9 UK Open Banking v4.0.1 AIS/consent endpoints to real data#2864hongwei1 wants to merge 1 commit into
hongwei1 wants to merge 1 commit into
Conversation
Replace static spec-example responses with real OBP connector calls for the account-access-consents, accounts, balances, and transactions endpoints in UK Open Banking v4.0.1 AccountInfo — the same 9 endpoints that carry real implementations in v3.1, covering the full consent lifecycle plus the 5 endpoints OBP-Hola actually calls. Connector call sequences are carried over from the v3.1 handlers (Http4sUKOBv310AccountAccess/Accounts/Balances/Transactions) since the underlying data access is unchanged between API versions. Response shaping needed a new factory (JSONFactory_UKOpenBanking_401) because the v4.0.1 Account/Balance/Transaction resources changed shape from v3.1 (AccountTypeCode replaces AccountType, single-string SchemeName, added TotalValue/TransactionMutability/Status codes, etc.). getAccounts, getAccountsAccountIdBalances and getAccountsAccountIdTransactions call checkUKConsent, which requires a live Hydra OAuth2 introspection endpoint with no local test double, so those three keep the same "authenticated -> not 401" assertion already used for their v3.1 counterparts. The other 6 endpoints get full scenario coverage: real seeded data, unknown-consent and empty-data paths, and a full create -> get -> delete -> get consent lifecycle.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Http4sUKOBv310AccountAccess/Accounts/Balances/Transactions); a newJSONFactory_UKOpenBanking_401shapes the results into the v4.0.1 response schema, which changed from v3.1 (AccountTypeCodereplacesAccountType, single-stringSchemeName, addedTotalValue/TransactionMutability/status codes, etc.).Test plan
mvn install -pl .,obp-commons -am -DskipTests+mvn test-compile -pl obp-api -amon JDK 25 — compiles cleanUKOpenBankingV401AccountInfoTests(new full scenario matrix: unauthenticated → 401, real seeded data → 200/201/204, unknown consent/account paths, full consent create → get → delete → get lifecycle) — all greencode.api.UKOpenBankingpackage (v3.1 + v4.0.1, 315 tests) — all green, confirms the v3.1 reference implementations are untouchedgetAccounts/getAccountsAccountIdBalances/getAccountsAccountIdTransactionscallcheckUKConsent, which requires a live Hydra OAuth2 introspection endpoint with no local test double — these three keep the sameauthenticated -> not 401assertion already used for their v3.1 counterparts (seeUKOpenBankingV310AisTests)