Enforce UK consent check on aggregate endpoints; fix background-launch hang#2870
Closed
hongwei1 wants to merge 6 commits into
Closed
Enforce UK consent check on aggregate endpoints; fix background-launch hang#2870hongwei1 wants to merge 6 commits into
hongwei1 wants to merge 6 commits into
Conversation
… endpoints GET /aisp/balances and GET /aisp/transactions fetched every private account for the caller without validating the bearer token's UK consent binding first, unlike every sibling AISP endpoint (including their own single-account counterparts). A DirectLogin or OAuth2 token with no bound consent fell through into the account-fetch path and surfaced as a 500 Unknown Error instead of the expected 403 OBP-35035, and callers with real consent got real account data with no consent enforcement at all. Add the same checkUKConsent + passesPsd2Aisp guard already used by getAccountsAccountIdBalances and getAccountsAccountIdTransactions so all five real-data AISP endpoints share one consent contract. Also fix createTransactionsJsonNew to take the AccountId from the request path instead of deriving it from the first transaction's bank account, which returned a null AccountId whenever the account had no transactions.
# Conflicts: # obp-api/src/test/scala/code/api/UKOpenBanking/v4_0_1/UKOpenBankingV401AccountInfoTests.scala
…ubstitution Redirecting to > >(tee "$RUNTIME_LOG") makes the tee process inherit this script's own stdout. A caller that captures this script's output with out=$(./flushall_build_and_run.sh --background ...) never sees EOF, because the long-running server (and the tee backing the substitution) never exits on its own — the command substitution hangs forever even though the server started successfully. Redirect straight to the log file instead.
checkUKConsent no longer needs a live Hydra introspection endpoint — it checks the Bearer token's consent_id claim against an AUTHORISED consent. Two comments describing the balances/transactions scenarios still referred to the removed Hydra dependency; align them with the class doc above, which was already corrected during the merge from Simon/develop.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flushall_build_and_run.sh's background server launch redirected through> >(tee "$RUNTIME_LOG"), a process substitution whoseteeinherits the script's own stdout. A caller that captures this script's output viaout=$(...)never sees EOF — because the long-running server never exits — so the capture hangs forever even after the server started successfully. Redirect straight to the log file instead.checkUKConsentmoved to a JWT consent_id-claim check.This branch also carries two commits from
Simon/develop(merged in) that assert the consent is valid for its API standard (OBP/BG/UK) — not authored by me, included because they were already on the shareddevelop-obpline when I merged to pick up its cleanup of stale Hydra references.Test plan
/obp-api-testsmoke test:run_tests_parallel.sh— 3125 tests, 0 failures; full build +/rootOK; fast incremental build +/rootOK (same git_commit on both)