Skip to content

Drop numbers from Wacky Worlds scenery#439

Merged
Gymnasiast merged 2 commits into
OpenRCT2:masterfrom
Gymnasiast:drop-numbers
Jun 23, 2026
Merged

Drop numbers from Wacky Worlds scenery#439
Gymnasiast merged 2 commits into
OpenRCT2:masterfrom
Gymnasiast:drop-numbers

Conversation

@Gymnasiast

Copy link
Copy Markdown
Member

No description provided.

AaronVanGeffen
AaronVanGeffen previously approved these changes May 7, 2026

@AaronVanGeffen AaronVanGeffen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wonder to what extent this will affect identification. I see no problem dropping it from animatronics (e.g. hippo 1/2), but I wonder if it will help the situation with e.g. wall pieces. What's your take on this?

Edit: heh, didn't mean to approve this.

@AaronVanGeffen AaronVanGeffen dismissed their stale review May 7, 2026 19:36

Oops, not yet

@Gymnasiast

Copy link
Copy Markdown
Member Author

Ah right, I haven’t given a lot of context here. This was the result of a conversation that Maji and I had. Only WW seems to do this (vanilla does not, neither does TT), and the numbers are often out of order to boot. It just seemed like an unnecessary complication.

@ZeeMaji

ZeeMaji commented May 7, 2026

Copy link
Copy Markdown
Contributor

It'd also make the groups easier to maintain too, if we ever wish to change the order of items we won't have to worry about updating the names of the few items that are numerically labelled for some reason. Presently only about two dozen sets of items from solely WW use this as well so it just seems like yet another frontier fumble since they didn't even apply it to everything in the pack. (Antarctic theme has 0 numerically labelled items, South America theme only has 4.)

@ZeeMaji

ZeeMaji commented May 7, 2026

Copy link
Copy Markdown
Contributor

From a glance at the list of diffs, to me the only one that seems like it might need a tweak is the suspension bridge start/tower pieces. I think just removing the 'side' part of the name and replacing it with 'Section' (which is already used by the cable piece from the set) would suffice.

@ZeeMaji ZeeMaji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skyscraper metal set pieces from the north america theme and tudor roof extension piece from the europe theme still have numbers in their names.

ksnip_20260507-171203 ksnip_20260507-171204

@ZeeMaji

ZeeMaji commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The changes in-game looked fine to me, the few objects that slipped through last time are accounted for now. Although the diffs are pretty big from the recent localisation merge.

@AaronVanGeffen AaronVanGeffen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we automatically remove the numbers for the object translations as well? Not sure if that needs to happen in the localisation repository, though.

Fine with me, either way.

@Gymnasiast Gymnasiast merged commit e060365 into OpenRCT2:master Jun 23, 2026
2 checks passed
@Gymnasiast Gymnasiast deleted the drop-numbers branch June 23, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants