Feat/fe testing infrastructure#144

Open

romanetar wants to merge 5 commits into

feat/mfa---login-ui-flowfrom

feat/fe-testing-infrastructure

romanetar commented Jun 30, 2026

Contributor

ref https://app.clickup.com/t/9014802374/86bak2ur6


          feat: first tests

f7b8a91

Signed-off-by: romanetar <roman_ag@hotmail.com>

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3f857487-acc3-49b5-a97d-e389b8d77fa6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/fe-testing-infrastructure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar force-pushed the feat/fe-testing-infrastructure branch from 7acd03d to deb8d3c Compare

June 30, 2026 16:29

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar force-pushed the feat/fe-testing-infrastructure branch from deb8d3c to 94943cf Compare

June 30, 2026 17:48

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.


          feat: add testing infrastructure for login MFA flow and E2E suite

3b111f5

Signed-off-by: romanetar <roman_ag@hotmail.com>

romanetar force-pushed the feat/fe-testing-infrastructure branch from 94943cf to 3b111f5 Compare

June 30, 2026 17:54

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar requested a review from smarcet

June 30, 2026 18:00

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

smarcet reviewed

View reviewed changes

.github/workflows/push.yml Outdated

romanetar force-pushed the feat/fe-testing-infrastructure branch from 567eaf8 to b434b4e Compare

June 30, 2026 18:19

smarcet reviewed

View reviewed changes

.github/workflows/pull_request_unit_tests.yml Outdated

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar force-pushed the feat/fe-testing-infrastructure branch from b434b4e to b02637e Compare

June 30, 2026 18:24

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar force-pushed the feat/fe-testing-infrastructure branch from b02637e to ece0a61 Compare

June 30, 2026 18:31

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar force-pushed the feat/fe-testing-infrastructure branch from ece0a61 to 88d296e Compare

June 30, 2026 18:45

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar force-pushed the feat/fe-testing-infrastructure branch from 88d296e to f7b8536 Compare

June 30, 2026 19:04

github-actions Bot commented Jun 30, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar force-pushed the feat/fe-testing-infrastructure branch from f7b8536 to 127ce7a Compare

July 1, 2026 13:52

github-actions Bot commented Jul 1, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.


          feat: add testing infrastructure for login MFA flow and E2E suite

Signed-off-by: romanetar <roman_ag@hotmail.com>

romanetar force-pushed the feat/fe-testing-infrastructure branch from 127ce7a to 6248346 Compare

July 1, 2026 14:10

github-actions Bot commented Jul 1, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.


          test: isolate login.spec.ts in CI, fix MFA mock route ordering

dd3d5eb

Comment out login-mfa-flow.spec.ts and register.spec.ts so CI runs
login.spec.ts alone to verify it now passes without account lockout
interference. Also fix the MFA beforeEach mock: fulfill() must run
before unroute(), otherwise Playwright auto-resolves the in-flight
route on unroute and the later fulfill() throws "Route is already
handled" - which was letting the real POST through with a wrong
password and locking out test@test.com.

github-actions Bot commented Jul 1, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

1 similar comment

github-actions Bot commented Jul 1, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.


          test: re-enable MFA and registration e2e suites

1b6f66d

login.spec.ts verified green in isolation; re-enable the MFA flow
suite (route-ordering fix already applied) and the registration
suite now that the account-lockout cascade is gone.

Signed-off-by: romanetar <roman_ag@hotmail.com>

romanetar force-pushed the feat/fe-testing-infrastructure branch from e995647 to 1b6f66d Compare

July 1, 2026 14:59

github-actions Bot commented Jul 1, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-144/

This page is automatically updated on each push to this PR.

romanetar requested a review from smarcet

July 1, 2026 15:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet