Fix path callback Swift name#28
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 8 8
Lines 356 356
=====================================
Misses 356 356 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Swift importer name for path callback flags by using the valid nested type name
ORBPath.CallbacksFlagsinstead of the unsupportedORBPath.Callbacks.Flagsspelling.This keeps the callback flag type named for Swift users instead of leaving it as a plain C import, and updates the non-CoreGraphics fallback Swift declarations to match the imported API shape.
Root Cause
The Swift importer accepts the
ORBPath.Callbacksrecord mapping, but rejects the deeperORBPath.Callbacks.Flagsrecord name and reports an invalid base identifier warning.Validation
OpenRenderBox.hthroughswiftc -typecheck -import-objc-headerand verifiedORBPath.CallbacksFlagsimports without the warning.OPENSWIFTUI_USE_LOCAL_DEPS=1 OPENRENDERBOX_USE_LOCAL_DEPS=1 OPENATTRIBUTEGRAPH_USE_LOCAL_DEPS=1 swift build --target OpenSwiftUICallbacks.Flagsor invalidswift_namewarning matches.