Run Compute in the UI test workflow#929
Conversation
37b4610 to
d1b3510
Compare
|
/uitest all all-configs |
🤖 Augment PR SummarySummary: This PR extends the UI test workflow to run OpenSwiftUI with the Compute backend and routes CI setup through the same Changes:
Technical Notes: Compute configurations set 🤖 Was this summary useful? React with 👍 or 👎 |
| @MainActor | ||
| @Suite(.snapshots(record: .never, diffTool: diffTool)) | ||
| struct AnimationCompletionUITests { | ||
| @Test |
There was a problem hiding this comment.
@Test was removed from logicalAndRemovedComplete(), which means this test will no longer execute at all (not just be skipped). If the intent is to suppress a flaky/Compute-only failure, consider using an explicit .disabled/known-issue annotation so the omission is intentional and visible in results.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| mise exec -- tuist install | ||
| mise exec -- tuist generate --no-open | ||
| if [[ "${{ inputs.compute }}" == "true" ]]; then | ||
| ./setup.sh --compute |
There was a problem hiding this comment.
Now that CI generates the Example project via Example/setup.sh, changes to that script (and its associated mise*.toml env files) can affect UI test setup. Consider adding those paths to .github/workflows/uitests.yml on.push.paths so setup regressions will reliably trigger UI tests on main.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Summary
Example/setup.shso CI uses the same setup path as local runs./uitestflexible enough to request individual or all renderer/backend configurations.Why
This lets CI exercise the Compute setup path directly, so setup regressions like #927 are covered by UI tests instead of only being found locally.
Validation
OSUI_UITests+ Compute: passedOSUI_UITests+ Compute: passed