test: Make compile test more sane#1108
Merged
Merged
Conversation
Bing-su
approved these changes
Jul 9, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 9, 2026
`npm@11.18.0` and `npm@12.0.0` include a breaking change (for us) which causes `npx <foo>` to print the remapped node command out to stderr, which triggers the error logic that was originally written for this test. Instead of treating anything printed to stderr, capture the exit code of the subprocess and treat a non-zero exit code as an error. c9b05b3
github-actions Bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Jul 9, 2026
`npm@11.18.0` and `npm@12.0.0` include a breaking change (for us) which causes `npx <foo>` to print the remapped node command out to stderr, which triggers the error logic that was originally written for this test. Instead of treating anything printed to stderr, capture the exit code of the subprocess and treat a non-zero exit code as an error. c9b05b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm@11.18.0andnpm@12.0.0include a breaking change (for us) which causesnpx <foo>to print the remapped node command out to stderr, which triggers the error logic that was originally written for this test.Instead of treating anything printed to stderr, capture the exit code of the subprocess and treat a non-zero exit code as an error.