Skip to content

Bracket IPv6 address literals in HTTP/nikto/testssl host strings #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RamsesRodenburg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bracket IPv6 address literals in HTTP/nikto/testssl host strings #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions analyze_hosts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,24 @@ def requests_get(url, options, headers=None, allow_redirects=True):
return request


def bracket_ipv6(host):
"""Wrap an IPv6 address literal in [] for use in a URL or host:port string.

IPv6 literals must be bracketed per RFC 3986 (e.g. https://[2001:db8::1]:443
and [2001:db8::1]:443). IPv4 addresses and hostnames are returned unchanged.
nmap takes the bare literal (with -6), so this is intentionally not used there.
"""
return f"[{host}]" if ":" in host else host


def http_checks(host, port, protocol, options, logfile, host_results):
"""Perform various HTTP checks."""
ssl = False
if "ssl" in protocol or "https" in protocol:
ssl = True
url = f"https://{host}:{port}"
url = f"https://{bracket_ipv6(host)}:{port}"
else:
url = f"http://{host}:{port}"
url = f"http://{bracket_ipv6(host)}:{port}"
if options["nikto"]:
do_nikto(host, port, options, logfile, host_results)
if options["framework"]:
Expand Down Expand Up @@ -621,7 +631,7 @@ def check_trace(host, port, options, logfile, host_results):
str(options["timeout"]),
"-X",
"TRACE",
f"{host}:{port}",
f"{bracket_ipv6(host)}:{port}",
]
_result, _stdout, _stderr = execute_command(
command, options, logfile
Expand All @@ -645,7 +655,7 @@ def do_nikto(host, port, options, logfile, host_results):
"-ask",
"no",
"-host",
f"{host}:{port}",
f"{bracket_ipv6(host)}:{port}",
"-maxtime",
f'{options["maxtime"]}s',
"-nointeractive",
Expand Down Expand Up @@ -879,7 +889,7 @@ def do_testssl(host, port, protocol, options, logfile, host_results):
command += ["--starttls", "smtp"]
logging.info("%s Starting testssl.sh on port %s", host, port)
_result, stdout, _stderr = execute_command(
command + [f"{host}:{port}"], # pylint: disable=unused-variable
command + [f"{bracket_ipv6(host)}:{port}"], # pylint: disable=unused-variable
options,
logfile,
)
Expand Down