Add oras surfing and fishing encounters (Part 1) by ConnorMolz · Pull Request #1542 · PokeAPI/pokeapi

ConnorMolz · 2026-06-05T12:29:08Z

Change description

I am adding the surfing and fishing encounters from ORAS to the project.
I will add in this PR Route 101 to 109, Oldale Town, Petalburg City, Rustboro City, Dewford Town and Slateport City

AI coding assistance disclosure

I used only the inline assistance of VS-Code (not sure if its AI).

Contributor check list

I have written a description of the contribution and explained its motivation.
I have written tests for my code changes (if applicable).
I have read and understood the AI Assisted Contribution guidelines.
I will own this change in production, and I am prepared to fix any bugs caused by my code change.

…xpected)

Naramsim · 2026-06-13T13:29:59Z

Hi I completely missed this PR, sorry for the late reply. I'll try to see if the additions round up in the next days

ConnorMolz · 2026-06-17T09:15:29Z

Hi I completely missed this PR, sorry for the late reply. I'll try to see if the additions round up in the next days

Hi,

All fine was busy last days...
I finished the Part 1 so far. To the AI Guidelines I used AI to create a local debug script (local and not pushed)

… + fix some jotho double ids

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds new encounter data and normalizes encounter method records in the v2 CSV dataset.

Changes:

Appends new encounter rows for additional location areas/versions.
Introduces new encounter slots tied to newly added methods/slot distributions.
Fixes missing IDs in encounter methods and adds prose for new methods.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
data/v2/csv/encounters.csv	Adds new encounter rows referencing newly-added slot IDs.
data/v2/csv/encounter_slots.csv	Adds new encounter slot definitions to support the new encounters/methods.
data/v2/csv/encounter_methods.csv	Fills in missing IDs and adds a new encounter method.
data/v2/csv/encounter_method_prose.csv	Adds new prose rows for honey-tree and poke-nav-surfing.

Naramsim · 2026-06-22T07:23:29Z

 54,hidden-grotto,54
-55,honey-tree,54
+55,honey-tree,54
+56,poke-nav-surfing,55


@ConnorMolz

Maybe we should just have poke-nav as the method, seeing as we don't have something like that for other similar grass encounters in the game.

-55,9,Slathering a Honey Tree with Honey and waiting for a Pokémon to appear.
+55,9,Slathering a Honey Tree with Honey and waiting for a Pokémon to appear.
+56,9,Surfing and using the PokéNav Plus in Pokémon Omega Ruby and Alpha Sapphire
+56,6,Surfen und das Poké-Multi-Navi nutzen in Pokémon Omega Rubin und Alpha Saphire


ConnorMolz · 2026-06-17T11:13:06Z

@Naramsim I dont know why there still a Merge conflict, I fixed it local...

…xpected)

merge to newst

ConnorMolz · 2026-06-17T11:28:55Z

Sorry for the Ping got it solved localy

Naramsim · 2026-06-22T07:23:29Z

 54,hidden-grotto,54
-55,honey-tree,54
+55,honey-tree,54
+56,poke-nav-surfing,55


@ConnorMolz

Naramsim · 2026-06-22T07:34:31Z

 1496,10,1,8,5
 1497,10,1,9,5
 1498,10,1,10,5
+1499,16,5,,60


Could you reveal a bit how you added all these numbers? I just checked the entries for Frillish and they seem ok.

I did a little reverse engeniering on some data, and copied the structure for the data I added.

As data source I used the german vatient of Bulbepedia (https://www.pokewiki.de/Hauptseite)

Thanks! Can you change the order in the file above, fix again the conflicts?

These are all missing the slot number, these should be added in as well. For example,

Suggested change

1499,16,5,,60

1499,16,5,1,60

jemarq04

I've added some comments as I reviewed the contributions. Not sure why encounters in Heartgold/Soulsilver were added to this? This is not in the scope of the PR.

Also, regarding the PokeNav encounters, we should just use one encounter slot set at 100% rarity since these seem to be chosen at an undetermined rarity. I'd rather not choose an arbitrary 60/35/5 split between the possible encounters.

jemarq04 · 2026-06-22T16:22:09Z

 1496,10,1,8,5
 1497,10,1,9,5
 1498,10,1,10,5
+1499,16,5,,60


These are all missing the slot number, these should be added in as well. For example,

Suggested change

1499,16,5,,60

1499,16,5,1,60

jemarq04 · 2026-06-22T16:23:54Z

 54,hidden-grotto,54
-55,honey-tree,54
+55,honey-tree,54
+56,poke-nav-surfing,55


Maybe we should just have poke-nav as the method, seeing as we don't have something like that for other similar grass encounters in the game.

jemarq04 · 2026-06-22T17:10:30Z

+75523,16,236,1487,190,15,16
+75524,15,241,1482,163,15,16
+75525,16,241,1482,163,15,16
+75526,15,241,1483,204,15,16


Suggested change

75523,16,236,1487,190,15,16

75524,15,241,1482,163,15,16

75525,16,241,1482,163,15,16

75526,15,241,1483,204,15,16

Why did this PR add anything to do with headbutt encounters in Johto?

jemarq04 · 2026-06-22T17:15:53Z

+75291,25,395,1499,72,20,25
+75292,25,395,1500,278,20,20
+75293,25,395,1501,279,25,30
+75294,25,395,1502,129,10,15
+75295,25,395,1503,72,5,5
+75296,25,395,1504,129,25,25
+75297,25,395,1505,72,25,25
+75298,25,395,1506,320,25,25
+75299,25,395,1507,320,30,40
+75300,26,395,1499,72,20,25
+75301,26,395,1500,278,20,20
+75302,26,395,1501,279,25,30


Suggested change

75291,25,395,1499,72,20,25

75292,25,395,1500,278,20,20

75293,25,395,1501,279,25,30

75294,25,395,1502,129,10,15

75295,25,395,1503,72,5,5

75296,25,395,1504,129,25,25

75297,25,395,1505,72,25,25

75298,25,395,1506,320,25,25

75299,25,395,1507,320,30,40

75300,26,395,1499,72,20,25

75301,26,395,1500,278,20,20

75302,26,395,1501,279,25,30

75291,25,395,1523,72,20,25

75292,25,395,1524,278,20,20

75293,25,395,1525,279,25,30

75294,25,395,1502,129,10,15

75295,25,395,1503,72,5,5

75296,25,395,1504,129,25,25

75297,25,395,1505,72,25,25

75298,25,395,1506,320,25,25

75299,25,395,1507,320,30,40

75300,26,395,1523,72,20,25

75301,26,395,1524,278,20,20

75302,26,395,1525,279,25,30

The surfing encounters in Route 103 should be at rates 65/30/5% (not 60/35/5 as was used).

jemarq04 · 2026-06-22T17:17:27Z

+75338,25,350,1517,341,30,40
+75339,26,350,1508,183,15,15
+75340,26,350,1509,184,20,25
+75341,26,350,1510,283,20,20


Suggested change

75341,26,350,1510,283,20,20

75341,26,350,1510,283,15,15

Surskit should be level 15 in Petalburg City, to match what was given in Omega Ruby.

ConnorMolz and others added 8 commits June 5, 2026 10:45

Add Tentacool to hoenn-route-103 (test if everthing is working like e…

7ed77cd

…xpected)

Add route 103

8e9edae

Add AS to route 103

493d227

Add route 102 and Petalburg city

45a4fd9

Add route 104

2ed7944

Add poké-nav to the encounter methods

be6970a

Add route 105

9f5bdc9

Add Route 106, fix route 105 and add Slateport city

3d7b2a4

ConnorMolz changed the title ~~Add oras surfing and fishing encounters~~ Add oras surfing and fishing encounters (Part 1) Jun 5, 2026

Add Route 107, 108, 109 and Dewford Town

b506c27

update encounter_slot ids and encounter ids to resolve merge conflict…

b66e094

… + fix some jotho double ids

ConnorMolz marked this pull request as ready for review June 17, 2026 10:45

Copilot AI review requested due to automatic review settings June 17, 2026 10:45

Copilot AI reviewed Jun 17, 2026

View reviewed changes

ConnorMolz and others added 3 commits June 17, 2026 13:23

Add Tentacool to hoenn-route-103 (test if everthing is working like e…

40e3a9a

…xpected)

fix merge conflict

4324dd9

Merge pull request #1 from ConnorMolz/master

e1aac1a

merge to newst

Naramsim requested changes Jun 22, 2026

View reviewed changes

jemarq04 suggested changes Jun 22, 2026

View reviewed changes

Uh oh!

Conversation

ConnorMolz commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change description

AI coding assistance disclosure

Contributor check list

Uh oh!

Naramsim commented Jun 13, 2026

Uh oh!

ConnorMolz commented Jun 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ConnorMolz commented Jun 17, 2026

Uh oh!

ConnorMolz commented Jun 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jemarq04 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ConnorMolz commented Jun 5, 2026 •

edited

Loading