Add new fields to evolutions (version_group_id, is_default, and evolved_form_id)#1558
Conversation
…larity on multiple evolution chains
…/update-evolutions
|
Whoa, thanks for the hard job. I'll try to review some CSV later. I trust you on the implementation, so many issues will be closed with this merged in). |
|
Whao, that's crazy! I checked Muk and Persian. Great and clean solution, sorry for not merging it earlier :) |
|
And could align the docs? Amongh the new three fields |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
I'm glad you're happy with the updates! This has been something in the back of my mind for some time on how to improve. As far as the docs, I have a branch waiting to upload - I'll check it over and make the PR for it soon. My intention with |
Change description
I've been brainstorming since my last PR with evolution schema changes on how to make things a bit clearer to the user. For example, retrieving the evolutions for Probopass gives an enormous list, but only one of them is the most relevant for newer games. Plus, getting evolutions for Sandshrew gives two different methods both to "Sandslash", since we mark the species as the endpoints.
This PR aims to solve some of the issues with clarity. I've added
version_group_idandis_defaultto make it clearer which evolutions are considered the "main" one going forward to new generations (i.e. it is safe to assume that Squirtle evolves at level 16). The version group ID would describe the version group that introduced this evolution. For example, Cyndaquil evolves to Quilava at 17 in Hisui (version_groupislegends-arceusandis_defaultis 0, since our assumption would be that in any other game it would evolve at level 14 as usual). The evolution from Quilava to Typhlosion and the one from Quilava to Hisuian Typhlosion while in Hisui are both default in this case. The Johto evolution is obvious, but I felt that the Hisuian one should also be default because any Quilava in Hisui will of course evolve to Hisuian Typhlosion and if we were to revisit this region, we should expect this behavior. A rule-of-thumb I think would be if you viewed the summary page for this pokemon on serebii (i.e. https://www.serebii.net/pokemon/quilava) if the evolution should be shown then it is a default evolution.To additionally help with the clarity of regional evolutions, I've added the
evolved_form_idto complement theregion_idandbase_form_idfields. Now an evolution like Meowth would have three default evolution chains:meowthtopersianbylevel-up,meowthtopersianwithbase_formofmeowth-alolaandevolved_formofpersian-alola, andmeowthtoperrserkerwithbase_formofmeowth-galar.Lastly, I added a couple evolutions I missed for Leafeon and Glaceon in Sun/Moon.
I know I tend to be a bit verbose in these descriptions, but I wanted to make the usage and motivation as clear as I can!
Closes #639, closes #666, closes #724, closes #729, closes #931, closes #1068, closes #1266. (There were a lot of requests to clarify regional evolutions and some for linking versions lol.)
Contributor check list