Stdlib: get_defined_constants(true) extension groups (#17416)#17421
Merged
Conversation
…#17416) Extension constants registered via defineConstant() were lumped into the user bucket; Zend groups them by extension (calendar, hash, dom, etc.). Add ExtensionConstantGroups registry and route buildCategorized() through it so VM/JIT/AOT match php-src buckets including calendar/CAL_GREGORIAN. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtensionConstantGroupsregistry soget_defined_constants(true)buckets VM-defined extension constants by extension name (calendar, hash, dom, filter, standard, etc.) instead of lumping them intouser.StdlibModuleConstants(single source forModule::init()and categorization).calendar/CAL_GREGORIAN; sync spine (+4 units).php-src reference
Zend/zend_builtin_functions.c—get_defined_constants()categorized bucketsPHP implementation
ext/standard/ExtensionConstantGroups.php— extension name → registered constant mapext/standard/VmConstants.php—buildCategorized()iterates registryext/standard/StdlibModuleConstants.php— stdlib/date/zlib/json bootstrap mapsVerification
Closes #17416
Made with Cursor