Bootstrap: dedupe spine requires + VmObjectDebugType unit (#17412)#17447
Merged
Conversation
Remove duplicate require_once lines from parallel spine merges (clamp, date_set, intl constants) and add ext/standard/VmObjectDebugType.php so get_debug_type spine dependency is covered. Sync footnotes to 4284/4284 and refresh bootstrap-inventory.md. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_oncelines incompiler_lib_spine_smoke/main.php(parallel spine PR merge fallout — clamp, date_set, intl constants).ext/standard/VmObjectDebugType.phpto the spine beforeget_debug_type.php(dependency was in inventory but not required).docs/bootstrap-inventory.md.Closes #17412
Closes #17446
Root cause
Two racing spine-sync PRs duplicated the same
require_onceentries;VmObjectDebugType.phplanded on the vm.php path viaget_debug_type.phpwithout its own spine line.Verification
Made with Cursor