Skip to content

Bootstrap: dedupe spine requires + VmObjectDebugType unit (#17412)#17447

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-17412-spine-dedupe-vmobjectdebugtype
Jul 8, 2026
Merged

Bootstrap: dedupe spine requires + VmObjectDebugType unit (#17412)#17447
PurHur merged 1 commit into
masterfrom
agent/issue-17412-spine-dedupe-vmobjectdebugtype

Conversation

@PurHur

@PurHur PurHur commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove 12 duplicate require_once lines in compiler_lib_spine_smoke/main.php (parallel spine PR merge fallout — clamp, date_set, intl constants).
  • Add ext/standard/VmObjectDebugType.php to the spine before get_debug_type.php (dependency was in inventory but not required).
  • Sync M2 footnotes to 4284/4284 and refresh docs/bootstrap-inventory.md.

Closes #17412
Closes #17446

Root cause

Two racing spine-sync PRs duplicated the same require_once entries; VmObjectDebugType.php landed on the vm.php path via get_debug_type.php without its own spine line.

Verification

php script/check-selfhost-spine-count-sync.php
# check-selfhost-spine-count-sync: OK (spine 4284/4284 from compiler_lib_spine_smoke)

php script/check-selfhost-spine-coverage-sync.php
# check-selfhost-spine-coverage-sync: OK (spine covers all 4284 inventory files)

php script/check-selfhost-spine-deferred-sync.php
# check-selfhost-spine-deferred-sync: OK (0 deferred: (none); spine 4284/4284)

php script/bootstrap-inventory.php --check
# OK 4284/4284

vendor/bin/phpunit --filter testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits test/unit/BootstrapSelfhostBundleTest.php
# OK (1 test, 478 assertions)

Made with Cursor

Remove duplicate require_once lines from parallel spine merges (clamp,
date_set, intl constants) and add ext/standard/VmObjectDebugType.php so
get_debug_type spine dependency is covered. Sync footnotes to 4284/4284
and refresh bootstrap-inventory.md.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur PurHur merged commit b63e7c6 into master Jul 8, 2026
1 check failed
@PurHur PurHur deleted the agent/issue-17412-spine-dedupe-vmobjectdebugtype branch July 8, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant