Approve multisig proposals with any local signer, Add keystone support by n13 · Pull Request #563 · Quantus-Network/quantus-apps

n13 · 2026-07-11T11:27:28Z

Summary

Fixes #562: when multiple local accounts are signers of the same multisig, the app only tracked myMemberAccountId, so after that account signed there was no way for another local co-signer to approve.
Approval eligibility now considers all local accounts that are multisig members.
If more than one eligible local signer remains, tapping Approve opens a picker listing only accounts that have not already signed (or have a pending approval).
Keystone hardware signers no longer hit Mnemonic not found for signing — multisig approve/execute/cancel detect Keystone accounts and use the shared QR sign → scan signature → external submit path (same pattern as transfers).

Changes

Multi-local-signer helpers + unit tests
Signer picker sheet + EN/ID l10n
Proposal detail / approve confirm / activity row updates
Generic KeystoneExtrinsicSession + sign/scan screens
Hardware submit methods for multisig approve/execute/cancel

Test plan

Add 2 accounts on one device and create a 2-of-2 (or 2-of-N) multisig with both as signers
Create a proposal; first account auto-approves as proposer (or approve as account 1)
Open the proposal while account 1 has already signed — Approve remains available
With only one remaining unsigned local software signer, Approve goes straight to confirm and signs as that account
With two unsigned local signers, Approve shows the picker and excludes accounts that already signed
With a Keystone co-signer selected: confirm → Keystone QR screen → scan signature QR → approval submitted / pending state shown
Execute / cancel with a Keystone member also uses the QR flow
After all local signers have approved, button shows Already Signed / Done as before
Single-local-signer software multisigs still behave as before (no picker)

When multiple local accounts are members of the same multisig, the approve UX previously keyed only off myMemberAccountId. After that account signed, co-signers on the same device had no path to approve. Detect all local signers, keep Approve available until every local member has signed, and show an account picker when more than one unsigned local signer remains. Closes #562

Multisig approve/execute/cancel assumed a local mnemonic. When the selected signer is a Keystone account, hand off to a shared extrinsic QR sign + scan path (same pattern as transfers) and submit with the external signature. Adds KeystoneExtrinsicSession plus generic sign/scan screens, and hardware submit methods on TransactionSubmissionService.

n13 · 2026-07-11T12:15:20Z

dewabisma · 2026-07-13T03:38:38Z

    return signer;
  }

+  bool _isHardwareSigner(Account signer) {


I think we already have the extension for checking if account is hardware wallet or high security or other type of account, so we don't need to create new function everytime

this is a small utility method for debugging, it's ok

dewabisma · 2026-07-13T03:46:13Z

+                children: [
+                  Text(
+                    account.name,
+                    style: text.smallParagraph?.copyWith(color: colors.textPrimary, fontWeight: FontWeight.w600),


property color is unnecessary since we use textPrimary by default.

dewabisma · 2026-07-13T03:48:24Z

+    final frame = (size.width - 96).clamp(220.0, 300.0);
+    final progress = _expectedParts == null ? null : (_seenSeq.length / _expectedParts!).clamp(0.0, 1.0);
+
+    return Scaffold(


I remember we already have this keystone scan like screen, can't we refactor it to be reusable instead of creating totally new screen?

This is pretty bad.

Fixed.

dewabisma

So, does it mean when we have multiple eligible signers, we have to sign twice in the app now?

Some changes needed.

n13 · 2026-07-13T08:41:16Z

On the multiple eligible signers question: no, one tap on Approve does not make the user sign twice. The picker only chooses which eligible local account performs this approval, and that submits one signature. If the device owns another multisig member and the threshold still needs its approval, the user can deliberately approve again as that second account in a separate action. This PR makes that second local approval possible; it does not combine or automatically request both signatures.

general architecture improvement, renamed widgets so they make more sense

n13 · 2026-07-13T09:30:06Z

Fixed two DRY violations, please review again, commented on other comments

Tested the full hardware flow again, both send and msig approve

dewabisma · 2026-07-13T09:42:47Z

On the multiple eligible signers question: no, one tap on Approve does not make the user sign twice. The picker only chooses which eligible local account performs this approval, and that submits one signature. If the device owns another multisig member and the threshold still needs its approval, the user can deliberately approve again as that second account in a separate action. This PR makes that second local approval possible; it does not combine or automatically request both signatures.

I see, it means, we have to really deliberate even if the signers are both in the mobile app.

dewabisma · 2026-07-13T09:52:47Z

+        if (session.primaryDetail != null)
+          Text(
+            session.primaryDetail!,
+            style: text.smallTitle?.copyWith(color: colors.textPrimary),


Unnecessary color override.

dewabisma · 2026-07-13T09:54:00Z

+            style: text.detail?.copyWith(
+              color: colors.textMuted,
+              fontFamily: AppTextTheme.fontFamilySecondary,
+              fontSize: 12,


Unnecessary fontSize override

dewabisma

Looking great! Just few nits.

n13 · 2026-07-14T04:00:35Z

Co0l.. I do not think default overrides are an error, they're a feature (maybe we don't wanna rely on "default" and not be boxed in with all the other items who are using default, if any)

n13 added 4 commits July 11, 2026 19:27

xcode stuff

1ee4a75

format

b87ff4f

dewabisma reviewed Jul 13, 2026

View reviewed changes

Comment thread mobile-app/lib/services/transaction_submission_service.dart

dewabisma reviewed Jul 13, 2026

View reviewed changes

Comment thread mobile-app/lib/v2/screens/multisig/multisig_action_confirm_sheet.dart Outdated

dewabisma reviewed Jul 13, 2026

View reviewed changes

Comment thread mobile-app/lib/v2/screens/multisig/multisig_activity_section.dart

dewabisma reviewed Jul 13, 2026

View reviewed changes

Comment thread mobile-app/lib/v2/screens/send/keystone_sign_extrinsic_screen.dart Outdated

dewabisma reviewed Jul 13, 2026

View reviewed changes

Comment thread mobile-app/lib/v2/screens/send/keystone_sign_extrinsic_screen.dart Outdated

dewabisma requested changes Jul 13, 2026

View reviewed changes

n13 changed the title ~~fix: allow approving multisig proposals with any local signer~~ Approve multisig proposals with any local signer, Add keystone support Jul 13, 2026

n13 added 2 commits July 13, 2026 17:07

keystone duplicate screens removed

5ef861b

general architecture improvement, renamed widgets so they make more sense

DRY fix for submit with hardware wallet

315906e

dewabisma reviewed Jul 13, 2026

View reviewed changes

dewabisma approved these changes Jul 13, 2026

View reviewed changes

n13 merged commit 034d876 into main Jul 14, 2026

Uh oh!

Conversation

n13 commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

n13 commented Jul 11, 2026

Uh oh!

Uh oh!

dewabisma Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

n13 Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dewabisma Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

dewabisma Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

n13 Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dewabisma left a comment

Choose a reason for hiding this comment

Uh oh!

n13 commented Jul 13, 2026

Uh oh!

n13 commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dewabisma commented Jul 13, 2026

Uh oh!

dewabisma Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dewabisma Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

dewabisma left a comment

Choose a reason for hiding this comment

Uh oh!

n13 commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

n13 commented Jul 11, 2026 •

edited

Loading

n13 Jul 13, 2026 •

edited

Loading

n13 commented Jul 13, 2026 •

edited

Loading

dewabisma Jul 13, 2026 •

edited

Loading