Update student ability and json response to handle remix project#886
Open
cocomarine wants to merge 2 commits into
Open
Update student ability and json response to handle remix project#886cocomarine wants to merge 2 commits into
cocomarine wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the school-student authorization and the /api/projects/:identifier/context JSON payload so that student-owned remix projects can return the correct lesson/class context (derived from the original/parent lesson project).
Changes:
- Allow school students to access
show_contextfor their own remix projects (remixed from a student-visible lesson project). - Update the context Jbuilder view to derive
lesson_id/class_idfrom the project’s lesson or (for remixes) the parent’s lesson. - Add a request spec covering the remix context response for a student.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/requests/projects/show_context_spec.rb | Adds request coverage for fetching context for a student-owned remix project. |
| app/views/api/projects/context.json.jbuilder | Derives context lesson/class from @project.lesson or @project.parent.lesson to support remixes. |
| app/models/ability.rb | Grants students show_context permission for eligible remix projects they own. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test coverage91.86% line coverage reported by SimpleCov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, a migration, or upgrading a Gem. That kind of thing.