Skip to content

Revert "Add FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents (#90)"#91

Open
gabsow wants to merge 1 commit into
RedisLabsModules:masterfrom
gabsow:revert-90-fork-child-subevents
Open

Revert "Add FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents (#90)"#91
gabsow wants to merge 1 commit into
RedisLabsModules:masterfrom
gabsow:revert-90-fork-child-subevents

Conversation

@gabsow

@gabsow gabsow commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Reverts #90 ("Add FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents").

Companion to the core revert redis/redis#15432, which removes the FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents from Redis. This redismodule.h is a vendored copy of core's header, so it must track that revert — otherwise the SDK header would advertise two subevents that core no longer defines.

Why

The pre-fork module-coordination subevents are being reverted in core: as implemented they don't let a module actually refuse/delay a fork (no real handshake), the only deadlock they targeted is AddressSanitizer-specific (guarded in production by the allocator's own pthread_atfork), and there is no consumer going ahead with the approach. See redis/redis#15432 for the full rationale.

Change

Should land together with (or after) redis/redis#15432 so the SDK header stays in sync with core.


Note

Low Risk
Header-only constant removal with no runtime logic; low risk if shipped alongside the matching Redis core revert.

Overview
Reverts the vendored redismodule.h fork-child subevent definitions so they match redis/redis#15432, which drops the pre-fork coordination subevents from core.

REDISMODULE_SUBEVENT_FORK_CHILD_PRE and REDISMODULE_SUBEVENT_FORK_CHILD_CANCELLED are removed; REDISMODULE_SUBEVENT_FORK_CHILD_* is back to BORN=0, DIED=1, and _NEXT=2 only. The SDK header no longer advertises subevents that Redis will not emit.

Reviewed by Cursor Bugbot for commit 5056946. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabsow gabsow requested a review from galcohen-redislabs July 6, 2026 17:01
@gabsow gabsow marked this pull request as ready for review July 6, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants