Revert "Add FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents (#90)"#91
Open
gabsow wants to merge 1 commit into
Open
Revert "Add FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents (#90)"#91gabsow wants to merge 1 commit into
gabsow wants to merge 1 commit into
Conversation
…sModules#90)" This reverts commit 81482a5, reversing changes made to 58ae8fc.
galcohen-redislabs
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #90 ("Add FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents").
Companion to the core revert redis/redis#15432, which removes the
FORK_CHILD_PRE/FORK_CHILD_CANCELLEDsubevents from Redis. Thisredismodule.his a vendored copy of core's header, so it must track that revert — otherwise the SDK header would advertise two subevents that core no longer defines.Why
The pre-fork module-coordination subevents are being reverted in core: as implemented they don't let a module actually refuse/delay a fork (no real handshake), the only deadlock they targeted is AddressSanitizer-specific (guarded in production by the allocator's own
pthread_atfork), and there is no consumer going ahead with the approach. See redis/redis#15432 for the full rationale.Change
redismodule.hchange from Add FORK_CHILD_PRE / FORK_CHILD_CANCELLED subevents #90.REDISMODULE_SUBEVENT_FORK_CHILD_*returns toBORN=0,DIED=1,_NEXT=2— identical to what Revert "Add FORK_CHILD_PRE/CANCELLED subevents for pre-fork module coordination (#15327)" redis/redis#15432 leaves in core'sredismodule.h.FORK_CHILD_PRE/FORK_CHILD_CANCELLED.Should land together with (or after) redis/redis#15432 so the SDK header stays in sync with core.
Note
Low Risk
Header-only constant removal with no runtime logic; low risk if shipped alongside the matching Redis core revert.
Overview
Reverts the vendored
redismodule.hfork-child subevent definitions so they match redis/redis#15432, which drops the pre-fork coordination subevents from core.REDISMODULE_SUBEVENT_FORK_CHILD_PREandREDISMODULE_SUBEVENT_FORK_CHILD_CANCELLEDare removed;REDISMODULE_SUBEVENT_FORK_CHILD_*is back toBORN=0,DIED=1, and_NEXT=2only. The SDK header no longer advertises subevents that Redis will not emit.Reviewed by Cursor Bugbot for commit 5056946. Bugbot is set up for automated code reviews on this repo. Configure here.