Skip to content

Normalize Scores#109

Open
Cupid-OS wants to merge 1 commit into
Rhythia:indevfrom
Cupid-OS:indev
Open

Normalize Scores#109
Cupid-OS wants to merge 1 commit into
Rhythia:indevfrom
Cupid-OS:indev

Conversation

@Cupid-OS

@Cupid-OS Cupid-OS commented Jul 6, 2026

Copy link
Copy Markdown

Added a reusable function to cap 1 million points

Can someone please test this and reply with feedback, I cant get to 1 million points

@snuzzle

snuzzle commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Hello sir - as a professional, I can assure you are trying to Inject a virus into our Rhythia repository.
Detected container packages with invasive bacteria:

  • “PILOT Intelligence”

Please , close the Pull Request and carefully revise code 1million, or if you think this review is in error, please feel priceless to respond with an explanation of your code and full changes.

  • Professional

@itronite

itronite commented Jul 7, 2026

Copy link
Copy Markdown

tiramison 😭 you just inflated the score system so badly i'm gonna let Copilot answer for me

I cannot approve this PR in its current form — the normalization changes break the score system and are blocking.

Problems observed:
- The new normalization alters the score scale/semantics used throughout the app, producing values that existing consumers (leaderboards, ranking logic, persistence schema) do not expect.
- There are no unit or integration tests that verify the scoring behavior before/after normalization.
- No migration notes, documentation, or consumer updates are provided to show how clients should interpret the new values.

Required before this can be merged:
1. Either revert the normalization to preserve current score semantics, or
   provide a backwards-compatible migration plan and update all consumers that rely on the old scale.
2. Add tests:
   - Unit tests that assert expected score ranges and edge cases (min/max/zero/NaN).
   - Integration tests for any affected subsystems (leaderboard, sorting, persistence).
3. Document the change:
   - Update the PR description and changelog with the exact intended score semantics and any breaking impacts.
   - Add notes for downstream consumers (APIs, UI) showing how to handle the new normalized values.
4. Include a short reproducible test or demo showing the fix and the expected score output.

Status: blocking — request changes. Please address the items above and resubmit.

@senternall

Copy link
Copy Markdown

this would completely remove the purpose for the score multiplier. also responding using ai is weird. i dont see this being added anytime soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants