service: harden Collection FunctionImport handler from PR #298 review#300
Merged
Conversation
phanak-sap
commented
Jun 19, 2026
phanak-sap
commented
Contributor
- Hoist entity_set lookup above EntityType/Collection branches to eliminate duplication
- Guard against missing 'results' key with a descriptive PyODataException
- Add tests: empty collection, missing results key, total_count absent (ProgramError)
- Fix double blank line in test_function_import_collection_with_pagination_metadata
- Hoist entity_set lookup above EntityType/Collection branches to eliminate duplication - Guard against missing 'results' key with a descriptive PyODataException - Add tests: empty collection, missing results key, total_count absent (ProgramError) - Fix double blank line in test_function_import_collection_with_pagination_metadata
phanak-sap
force-pushed
the
review/fix-function-import-collection
branch
from
aabb1e3 to
90ab662
Compare
All status-related logic (errors and unexpected-2xx warnings) is consolidated into _handle_response_status, resolving the pylint R0912 violation.
phanak-sap
force-pushed
the
review/fix-function-import-collection
branch
from
90ab662 to
be72b3b
Compare
filak-sap
approved these changes
Jun 19, 2026
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.