Fix #89#317
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #89.
Implements the single stubbed derived-property computation in
SysML2.NET/Extend/ActionDefinitionExtensions.cs.Change
List<IActionUsage> ComputeAction(this IActionDefinition)previously threwNotSupportedException. It now implements the OCL derivation:as
[.. actionDefinitionSubject.usage.OfType<IActionUsage>()], with anArgumentNullExceptionguard on the subject. This mirrors the existingCalculationDefinitionExtensions.ComputeCalculationimplementation.Ordering contract
Per the metamodel (
ActionDefinition::action, constraintderiveActionDefinitionAction),actionisderived, orderedandusage(inherited fromDefinition) is likewisederived, ordered. The implementation preserves this contract:OfType<IActionUsage>()enumerates the orderedusagelist in source order and[.. ]materializes that order, soactionfollowsusage's ordering.ActionUsage → OccurrenceUsage → Usage, so theselectByKind(ActionUsage)filter overusage : Usage [0..*]is well-formed.Tests
SysML2.NET.Tests/Extend/ActionDefinitionExtensionsTestFixture.cs— the obsolete placeholder test (assertingNotSupportedException) is replaced withVerifyComputeActioncovering:ArgumentNullExceptionActionDefinition→ empty resultActionUsagereturned) + negative (bareUsagefiltered out)Solution builds with 0 errors; the fixture passes (1/1).