docs: correct stale architecture in CLAUDE.md#12
Merged
Conversation
- Project Structure: add osdl-server, osdl-proto, osdl-firmware-protocol crates; mark DirectSerial/TCP as real (not stubs); add onvif and espnow_dongle transports, the media/ plane, orchestrator.rs; move the runze codec to driver/builtins/ where it actually lives. - Build & Run: `cargo run --bin osdl serve` (gRPC server), drop the stale "24 tests" count. - Integration with Xyzen: the runner is a gRPC client of `osdl serve` (osdl-proto + tonic), NOT an embedded osdl-core crate dependency. Fix the diagram and list the real runner message types. Co-Authored-By: Claude <noreply@anthropic.com>
Reviewer's Guide将 File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your Experience访问你的 dashboard 以:
Getting HelpOriginal review guide in EnglishReviewer's GuideUpdates CLAUDE.md to accurately describe the current OpenSDL architecture, project structure, and Xyzen integration, including new crates, transport and media components, and the gRPC-based runner model. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
嗨 —— 我已经审阅了你的更改,一切看起来都很棒!
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进后续的代码审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
CLAUDE.mdhad drifted from the actual codebase. This corrects the stale architecture descriptions so the developer guide matches reality.Changes
Project Structure
osdl-server,osdl-proto,osdl-firmware-protocol.transport/:DirectSerialandTCPare marked(stub)but both are real implementations now — relabeled. Addedonvif.rsandespnow_dongle.rs.media/plane (mediamtx/onvif_camera),orchestrator.rs.runze codecwas listed underadapter/but actually lives indriver/builtins/runze.rs— moved/clarified. Added the rest of the driver builtins (emm,laiyu_xyz,sopa,xkc).Build & Run
cargo run --bin osdl→cargo run --bin osdl serve(the gRPC server is what actually boots the engine).Integration with Xyzen
osdl-coreis an optional crate dependency ofxyzen-runner(feature = "osdl"). That's no longer true: the runner is a pure gRPC client of a separateosdl serveprocess, depending onosdl-proto(tonic-generated) behind thefeature = "osdl". The engine + gRPC server live in theosdl serveprocess (TCP + UDS), spawned by the desktop host (lab_server.ts) or run standalone on a lab Pi.osdl_list_devices,osdl_send_command,osdl_device_online/offline,osdl_media_source_online, …).Verification
Every path referenced in the updated doc was checked against the working tree (crates, transport/adapter/driver/media modules,
osdl servesubcommand). No code changes.🤖 Generated with Claude Code
Summary by Sourcery
更新 CLAUDE.md,以反映当前的 OpenSDL 项目架构、构建/运行工作流以及 Xyzen 集成模型。
文档:
osdl serve子命令作为引擎和 gRPC 服务器的入口点。osdl serve进程的纯 gRPC 客户端,并列出实际使用的 runner 消息类型。Original summary in English
Summary by Sourcery
Update CLAUDE.md to reflect the current OpenSDL project architecture, build/run workflow, and Xyzen integration model.
Documentation:
osdl servesubcommand as the entrypoint for engine and gRPC server.osdl serveprocess and list the actual runner message types.