Add domain in default run_id#156
Open
JosephMarinier wants to merge 1 commit into
Open
Conversation
My only concern is that the domain name `medical_hr` contains an underscore, which is the separator we use between the bits of id here. A `run_id` like `<date>_medical_hr_en_<models>` is slightly confusing. Furthermore, `hr` is the language code for Croatian. A couple of solutions: 1. Write `medical-hr` instead of `medical_hr`. There are often dashes within language codes and within model names. But then, it doesn't match the domain name exactly. 2. Change our separator for something that risks fewer collisions, like a tilde `~`. 3. Live with it.
JosephMarinier
commented
Jun 19, 2026
| suffix = "_".join(v for v in self.model.pipeline_parts.values() if v) | ||
| lang = self.language.value | ||
| self.run_id = f"{datetime.now(UTC):%Y-%m-%d_%H-%M-%S.%f}_{lang}_{suffix}" | ||
| self.run_id = f"{datetime.now(UTC):%Y-%m-%d_%H-%M-%S.%f}_{self.domain}_{lang}_{suffix}" |
Collaborator
Author
There was a problem hiding this comment.
My only concern is that the domain name medical_hr contains an underscore, which is the separator we use between the bits of run_id here. A run_id like <date>_medical_hr_en_<models> is slightly confusing. Furthermore, hr is the language code for Croatian.
A couple of solutions:
- Write
medical-hrinstead ofmedical_hr. There are often dashes within language codes and within model names. But then, it doesn't match the domain name exactly. - Change our separator for something that risks fewer collisions, like a tilde
~. - Live with it.
- Not add the domain name (close this PR).
What do you think?
Collaborator
There was a problem hiding this comment.
hmm, I really like the addition of domain. what about using medicalhr? it won't match domain exactly but reduces the confusion with language codes and needed a new separator. I'm ok with medical-hr as well though
Collaborator
Author
There was a problem hiding this comment.
That's a good idea too!
What I like about medical-hr is that it's a reversible transformation; we're not losing any info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the domain name in the default
run_id.