Skip to content

Align Rollup config with package-wide ESM mode#345

Draft
Copilot wants to merge 2 commits into
copilot/migrate-from-tslint-to-oxlintfrom
copilot/344-fix-code-review-comment
Draft

Align Rollup config with package-wide ESM mode#345
Copilot wants to merge 2 commits into
copilot/migrate-from-tslint-to-oxlintfrom
copilot/344-fix-code-review-comment

Conversation

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This addresses the review thread on module semantics by making the tooling consistent with the repository’s package-level ESM configuration. Instead of scoping ESM to a single config extension, the Rollup config now participates in the app’s module mode directly.

  • What changed

    • Renamed rollup.config.mjsrollup.config.js
    • Updated Makefile build target dependencies and invocation to reference rollup.config.js
  • Why this matters

    • Removes mixed signaling between package-level "type": "module" and tool-specific file extensions
    • Keeps bundling config aligned with the stated module mode across the app/tooling boundary
  • Config/reference update

    $(STATIC_DIR)/main.js: $(shell find ts -name "*.ts") rollup.config.js tsconfig.json
    	npx rollup --config rollup.config.js

Copilot AI changed the title [WIP] Fix code according to review comment Align Rollup config with package-wide ESM mode Jun 17, 2026
Copilot AI requested a review from donatj June 17, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants