Dispatch CustomLauncherConfig to launch_custom in GLT trainer/inferencer#685
Merged
Conversation
Wire the CustomLauncherConfig resource-config branch into GLTTrainer.run() and GLTInferencer.run() so custom launchers shell out via launch_custom, routed with the appropriate GiGLComponents value. The branch is placed before the Vertex AI branch and does not go through the VAI execution path (whose command check is a VAI-specific concern). Add unit tests covering the custom-launcher dispatch: assert launch_custom is called once with the right proto, URIs, docker URIs, and component, and that launch_single_pool_job / launch_graph_store_enabled_job are not called. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mkolodner-sc
reviewed
Jul 7, 2026
mkolodner-sc
left a comment
mkolodner-sc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Kyle, this LGTM, though is there supposed to be tests with this PR, as per the description?
Add unit tests covering the custom-launcher dispatch: assert launch_custom is called once with the right proto, URIs, docker URIs, and component, and that launch_single_pool_job / launch_graph_store_enabled_job are not called.
Update the "not yet supported" and "unsupported resource config" messages in the GLT trainer/inferencer to include CustomLauncherConfig as a supported option. Re-add custom-launcher dispatch tests that run the configured command through a real subprocess (only get_resource_config is patched): a printf one-liner writes the GIGL_* env vars and appended args[] to a temp file, verifying env propagation and shell quoting end-to-end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Added tests now too :) |
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 18:54:37UTC : 🔄 @ 19:03:19UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:54:37UTC : 🔄 @ 20:00:20UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:54:38UTC : 🔄 @ 20:19:30UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:54:38UTC : 🔄 @ 20:22:01UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:54:39UTC : 🔄 @ 19:02:55UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:54:39UTC : 🔄 @ 18:56:35UTC : ✅ Workflow completed successfully. |
mkolodner-sc
approved these changes
Jul 7, 2026
mkolodner-sc
left a comment
mkolodner-sc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Kyle! LGTM provided tests pass
yliu2-sc
approved these changes
Jul 7, 2026
kmontemayor2-sc
requested review from
nshah-sc,
svij-sc,
xgao4-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the CustomLauncherConfig resource-config branch into GLTTrainer.run() and GLTInferencer.run() so custom launchers shell out via launch_custom, routed with the appropriate GiGLComponents value. The branch is placed before the Vertex AI branch and does not go through the VAI execution path (whose command check is a VAI-specific concern).
Add unit tests covering the custom-launcher dispatch: assert launch_custom is called once with the right proto, URIs, docker URIs, and component, and that launch_single_pool_job / launch_graph_store_enabled_job are not called.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO