Remove dead generate-hashed-requirements workflow#686
Draft
kmontemayor2-sc wants to merge 1 commit into
Draft
Conversation
The generate-hashed-requirements workflow is a pre-uv artifact that no longer functions: - It invokes `make generate_*_hashed_requirements` targets that no longer exist in the Makefile. - It produces `requirements/*_requirements_unified.txt` files that no longer exist in the repo and that nothing consumes. - Dependency installation now uses `uv sync --locked` against `uv.lock` (see requirements/install_py_deps.sh), which is the source of truth. Delete the workflow, and remove the stale Makefile comment that referenced the removed hashed-requirements targets and the `/make_cuda_hashed_req` comment command. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
generate-hashed-requirementsworkflow is a leftover from the pre-uvworld and no longer functions.make generate_*_hashed_requirementstargets that no longer exist in the Makefile (the Makefile onlyincludesgigl/dep_vars.env; none of those targets are defined). Dispatching it today fails with "No rule to make target".requirements/*_requirements_unified.txtfiles that no longer exist in the repo, and nothing else references them.uv sync --lockedagainstuv.lock(seerequirements/install_py_deps.sh), which is the source of truth for pinned deps.This PR deletes the workflow and removes the stale
Makefilecomment that pointed at the removed hashed-requirements targets and the/make_cuda_hashed_reqcomment command.No behavior change: the workflow was non-functional and unreferenced.