#795 Fix staging CI#796
Conversation
Prompts: - Implement a bash script here that clones the SolidOS/solid-logic repo from github, runs its build scripts, and uses npm to install it as a local depdency to solid-ui - Default to using the same branch name as the one were the CI is running, using the GITHUB_BASE_REF env variable AI work summary: - Introduced a new script `setup-ci.sh` to clone, build, and link the solid-logic repository as a peer dependency for CI. - Updated the CI workflow to run the setup script after installing npm dependencies. Co-Authored-By: Cursor <cursoragent@cursor.com>
|
That's cool, it does get a bit more complicated though like solid-panes for instance it depends on all the panes. I wonder if it would get to be a bit much in that case. |
The script shouldn't get over-complicated, it would just take a list of dependencies rather than assume that |
|
I am now working locally to test and build an entire staging of SolidOS in order to be able to test the Authn switch. While the script above is a nice solution to have, it is not realistic in say solid-panes where we need to pull in all repos. For these reasons, I would propose to go back to releasing when pushing on the staging of all repos. |
|
I'm closing this PR, as it doesn't seem like we'll be moving forward with this. Can reopen later if we decide to do it again, but looking at the comments in #795 it looks like we'll move forward with the prereleases approach instead. I have opened a separate PR that just fixes the login tests, though: #803. |
This PR fixes the issues we have in CI as described in #795.
The fix clones the
solid-logicdependency, and installs it locally before running the rest of the CI. This only works withsolid-logicnow, but this script could be refactored to take a list of dependencies that should be symlinked this way. Also, we could potentially use the same script in other repositories in the organization in order to run their respective CIs.Overall, this is a working solution but it isn't ideal. Even though the CI works, developers will still need to manage their own local dependencies. Maybe this isn't too much of a problem, given that the expected development workflow is to use the Lerna config from the
solidosrepository.If we want to improve this in the future, I can only think of two solutions: