macOS shell: original crash/tabs/history/menus + 19 rounds of Chrome-UX creature comforts#48
Open
mdheller wants to merge 70 commits into
Open
macOS shell: original crash/tabs/history/menus + 19 rounds of Chrome-UX creature comforts#48mdheller wants to merge 70 commits into
mdheller wants to merge 70 commits into
Conversation
…ome-aligned menus - Crash: NSWindow defaulted releasedWhenClosed=YES while held by a strong property → over-release → dangling self.window → EXC_BAD_ACCESS in objc_retain from the leaked address-dismiss event monitor. Set releasedWhenClosed=NO and remove both local event monitors on window close. - Tabs: tab width was floored at 80px so many tabs overflowed off-screen and pushed the + button out of view. Switch to Safari-style compress-to-fit with a 44px favicon-only floor; pin the + button to the right edge; add a compact (favicon-only, close-on-hover) mode for narrow tabs with full-title tooltips. - History: dedupe repeat visits, patch late-arriving titles via the title KVO (entries were recorded at didFinishNavigation before the title loaded), dedupe the History window by URL, and add Clear Browsing Data. - Menus: rebuild the bar to mirror Chrome on macOS — Chrome, File, Edit, View, History, Bookmarks, Tab, Window, Help — with Find/Developer submenus, Home, and Help.
…SPA history, dup shortcuts) Found while auditing the first pass: - Multi-window was broken: newWindow: created its BBDelegate as a local, and both NSApplication.delegate and NSWindow.delegate are weak, so the controller was deallocated on return → the second window's tabs/nav went inert. Retain every window controller in a static array; release (deferred) on windowWillClose. - Tabs still overflowed past ~28 because width was clamped UP to a 44px floor. Drop the up-clamp so tabs always compress to fit (Safari-style slivers) — every tab stays visible and clickable at any count. - History missed SPA navigations (pushState/replaceState/popstate never fire didFinishNavigation). Inject a hook that posts route changes to a new historynav message handler so in-app navigation on Gmail/YouTube/etc lands in history. - Removed duplicate key equivalents (⌘⇧B, ⌘⇧⌫ were each bound on two menus).
- Set releasedWhenClosed=NO on the Network Monitor, Firewall, Packet Capture, Security Monitor and History windows (same legacy over-release class as the main window, now closed defensively everywhere). - Tab bar now hosts the tab strip in a horizontal NSScrollView: tabs compress to a readable 44px floor, then the strip scrolls (Chrome-style) with the active tab brought into view, instead of shrinking to unreadable slivers at extreme counts. - Titles persist down to 72px before favicon-only compact mode.
…, rich context menu)
Tabs:
- Right-click tab menu: New Tab to the Right, Duplicate, Reload, Close,
Close Other Tabs, Close Tabs to the Right, Reopen Closed Tab.
- Drag-to-reorder (tracking-loop, commits on mouse-up so any tab is draggable).
- Middle-click closes a tab; Duplicate Tab in the Tab menu.
History/recently-closed:
- Recently-closed is now a stack of {url,title}; History ▸ Recently Closed is a
live submenu (newest first); Reopen Closed Tab reopens next to the current tab.
Address bar:
- Bookmark star (filled when bookmarked) toggles a bookmark; updates on navigation.
Page UX:
- Chrome-style hovered-link status bubble (bottom-left) via a hoverlink hook.
- Rich right-click menu: selection (Copy / Search for "…"), link (Open in New
Tab/Window, Copy Link Address), image (Open in New Tab, Copy Image Address),
plus Save Page As / Print / View Source / Inspect.
Two bugs made the Web Inspector silently no-op: - The private _WKInspector selector is 'show' (no colon); the code called 'show:' so respondsToSelector: was NO and nothing happened. - WKWebView.inspectable defaults to NO on macOS 13.3+; without it the inspector cannot open at all. Set inspectable=YES on every webview. Verified the corrected API path (inspectable settable, _inspector non-nil, responds to show). Added a graceful 'unavailable' alert if a future WebKit drops the API. Audit result: every menu + context-menu selector has a real implementation; this was the only action that ran but did nothing. toggleFullScreen rides NSWindow via the responder chain; the other private calls (_serverTrust, _setStorageBlockingPolicy) are @try-guarded and degrade safely.
Fix: the bookmark star was positioned over the network/read-aloud buttons
(address ended ~W-86, star spanned W-88..W-64, netBtn W-106..W-74). Reserve room
for the star AND the action-button group so the omnibox/star/buttons never overlap.
New Tab Page: replace the curated grid with the user's most-visited sites (top 8
hosts by visit frequency, non-private history), injected when the start page loads;
falls back to the curated shortcuts until there's enough history.
Per-site zoom: pageZoom is remembered per host (persisted), re-applied on
navigation + tab switch; the level flashes briefly in the status bubble (no extra
toolbar button, so no layout risk).
Find: show an approximate match count ("N matches") via a page-text count, since
WKFindResult exposes no count.
Downloads: a completed item now offers Open + Show in Finder.
Settings (replaces the bare search-engine alert): a proper preferences window with default search engine, homepage (used by Home / ⌘⇧H), show-bookmarks-bar, and clear-history-on-quit. Run modally so all control refs stay in scope; choices persist to NSUserDefaults and apply immediately. - Homepage wired into goHome:; bookmarks-bar preference restored at launch and persisted on toggle; clear-on-quit honored in applicationWillTerminate:. Bookmark Manager (Bookmarks ▸ Bookmark Manager, ⌥⌘B): a window listing all bookmarks (title/URL) with Open (double-click) and Remove, backed by a live datasource over the shared store.
Reader mode (View ▸ Show Reader, ⌃⌘R): extracts the main article by paragraph density and renders it in our own clean, controlled template (typographic CSS, light/dark), so layout is predictable; toggling again restores the original page. Middle-click a link → open in a new background tab (Chrome behavior), via a local OtherMouseDown monitor that probes for the link under the cursor; torn down on window close like the other monitors.
…redaction)
Private tabs already used a non-persistent WKWebsiteDataStore, but three on-disk /
in-memory traces leaked private browsing:
- Popups/window.open/target=_blank inherited the opener's ephemeral store yet the
new BBTab defaulted isPrivate=NO → its navigations were written to history and
saved for session restore. Now isPrivate is derived from the store
(!websiteDataStore.persistent), so popups from incognito stay incognito.
- BBEmitEvent wrote full navigation URLs to the on-disk provenance log for ALL
tabs. Private navigations are now redacted ({private:YES}) — the provenance model
still records that a governed navigation happened, without persisting where.
- The per-subresource netmon handler logged private-tab connections to the network
monitor; now skipped for private tabs (the didFinishNavigation push was already
gated).
…venance The privacy fix routed navigation.requested/committed through the emitNav: wrapper (URL redaction for private tabs), which still emits the same provenance events but no longer matches the literal BBEmitEvent(@"navigation...") the contract grepped for — breaking the build's verify gate. Accept either form so the invariant (navigation provenance is emitted) still holds.
Robustness (crash-proofing): - activateTab: bounds-guarded; nextTab/prevTab guard the empty/single-tab case (was integer %% by tabs.count → divide-by-zero if ever empty). - All tab context-menu handlers (ctxNewTabRight/Duplicate/Reload/Close/CloseOthers) validate the menu's stale tab index before indexing self.tabs. Omnibox (privacy + correctness): live search suggestions already shipped (DDG ac endpoint, on by default, no toggle, ignored private mode, and — a bug — always routed to DuckDuckGo regardless of the chosen engine). - Extracted BBSearch as the single engine source of truth; the search row and the fetched suggestions now route to the user's chosen engine (Kagi/Brave/Startpage). - Added a 'Search suggestions' toggle in Settings (default on); suggestions are suppressed entirely in private tabs and when disabled — no incognito keystrokes leave the machine.
…es, menu validation - Replace JS dialog stubs with real NSAlert sheets (alert/confirm/prompt/file-upload) - Chrome-style dialog abuse protection: after 3 dialogs/page, offer "Block additional dialogs" - Per-tab dialogCount/dialogsSuppressed reset on each navigation - BBAddressField subclass: Paste-and-Go in right-click context menu - Inline omnibox autocomplete: history/bookmark prefix completion, selection-based so typing replaces the suggestion, enabled by default, user-togglable in Settings - Branded error pages for DNS failure, no connection, timeout, SSL errors - didFailProvisionalNavigation: handler (was missing entirely) - NSURLErrorCancelled guard: suppress both fail handlers on user-Stop - validateMenuItem: Back/Forward/Stop/Reload/Reopen-Closed-Tab/Bookmark gray correctly; Reload menu title toggles to "Stop" while loading; Bookmark toggles label - Window NSWindowCollectionBehaviorFullScreenPrimary: Enter Full Screen menu item works - WKWebViewConfiguration: mediaTypesRequiringUserActionForPlayback=None (video autoplay) + allowsAirPlayForMediaPlayback=YES for AirPlay support
Tab suspension (memory management): - BBTab gains suspended/suspendedURL/lastActiveAt properties - suspendTab: loads a lightweight placeholder HTML, freeing the WKWebView process - wakeTab: reloads the real URL instantly on focus - suspendInactiveTabs: sweeps tabs idle > 5 min (configurable BBSuspendAfterSec) - Timer runs every 60s; active tab is never suspended - activateTab: stamps lastActiveAt on blur, wakes on focus Research Sessions (link management for researchers): - BBResearchItem (url/title/note/status: unread/reading/done/dismissed) - BBResearchSession (named collection, exportMarkdown, unreadCount) - BBResearchStore singleton — persists to ~/Library/Application Support/.../research-sessions.json - BBResearchManagerDS — dual-table data source for session manager window - Research menu: Cmd+Shift+R manager, Cmd+Shift+S add tab, collect all tabs, suspend now - Context menu: "Add Link to Research Session..." on links, "Add Page to Research Session..." - Session Manager window: session list (left) + item list (right), status icons ☐/…/✓/✗ - Actions: New Session, Delete Session, Export Markdown (NSSavePanel), Hand to Agent, Open Selected - Hand to Agent: proposes BBProposeAction research_session_hand_off with all unread URLs - Collect All Tabs: deduplicates, shows count, offers to open Session Manager - UniformTypeIdentifiers framework added for markdown export save panel
…cycling, memory pressure suspend, timer cleanup - Research manager: double-click any item row opens it in a new tab (via BBResearchOpenURL notification → researchURLNotification:) and marks it Reading - Status column click cycles ☐→…→✓→✗ inline without leaving the table (itemTableClicked: on BBResearchManagerDS) - Added Dismiss and Mark Done buttons alongside Open Selected in the bottom toolbar; window widened to 900px to fit - researchMarkDone: / researchDismissItem: set item status to Done/Dismissed and persist - startSuspendTimer now installs a DISPATCH_SOURCE_TYPE_MEMORYPRESSURE handler (WARN|CRITICAL) that fires suspendInactiveTabs: immediately on macOS memory pressure - windowWillClose: tears down suspendTimer (no dangling timer firing after window is gone) - 💤 moon.zzz favicon for suspended tabs in tab bar (from previous session, now compiled + shipped)
… aliases, nav-response policy - didReceiveAuthenticationChallenge: shows NSAlert sheet with username/password fields for HTTP Basic/Digest/NTLM; server-trust passes to default WebKit handling (auth was silently cancelled before) - decidePolicyForNavigationResponse: triggers WKDownload for Content-Disposition:attachment and non-displayable MIME types - muteTab: toggles JS-level audio/video mute on active tab; tab bar shows 🔇 (speaker.slash.fill) for muted tabs; validateMenuItem: toggles label Mute/Unmute Tab - contextSaveImage: downloads image URL via NSSavePanel for right-click "Save Image As…" - bookmarkAllTabs: (Cmd+Shift+D) bookmarks all non-private, non-internal tabs deduplicating against existing bookmarks - Cmd+K as second address-bar focus shortcut (Chrome parity alongside Cmd+L) - Cmd+Shift+H as second Show Full History shortcut (Chrome parity alongside Cmd+Y) - collectAllTabsToSession: gains "Suspend Tabs" button on the confirmation alert - validateMenuItem: readAloud: toggles label between "Read Aloud" and "Stop Reading"
…s — preserve [20260630]
…sistence groundwork - Pinned tabs: kTabPinnedW (36px) icon-only slots at left of tab bar; close button hidden; Cmd+W blocked; right-click to pin/unpin; Pin Tab in Tab menu; validateMenuItem: toggles Pin/Unpin label - Tab right-click menu now includes: Pin/Unpin, Mute/Unmute, Suspend/Wake, Add to Research Session, New Tab to Right, Close Tab (disabled if pinned), Close Other Tabs, Close Tabs to Right, Reopen Closed Tab - ctxTogglePinTab: / ctxToggleMuteTab: / ctxToggleSuspendTab: implement right-click state toggles - bookmarkAllTabs: (Cmd+Shift+D) added — bookmarks every non-private open tab, skipping duplicates - pinCurrentTab: added to Tab menu with validateMenuItem: toggle
…ed+muted, tab right-click consolidation
- Camera/mic permission dialog now shows "Remember for this site" checkbox (on by default); persists grant/deny in NSUserDefaults keyed by BBMediaPerm_{kind}_{host}; subsequent requests from same host skip the prompt
- Session save now stores array of dicts {url, pinned, muted} instead of bare string array; backward-compatible with old string format on restore
- Session restore re-applies pinned and muted state to each tab, including re-firing the muted JS injection for muted tabs
- Suspended tabs use suspendedURL (not webView.URL) in the save path so their URL isn't lost
…tion URL update, favicon session persistence, settings improvements - runBeforeUnloadConfirmPanelWithMessage: shows "Leave / Stay" alert sheet so sites with unsaved data can prevent navigation - windowShouldClose: warns when ≥2 non-pinned tabs are open; informs user tabs will be session-restored - didCommitNavigation: updates URL bar at commit time (not just finish), correctly shows final URL after redirect chains - Session save now includes title + base64 PNG favicon per tab; restore eagerly applies title+favicon so pinned tabs render correctly before the page loads; backward compatible with old string array format - Settings window: +40px height, new "Site permissions:" row with "Clear All Media Permissions…" button that removes all BBMediaPerm_ keys from NSUserDefaults - clearMediaPermissions: action implementation - Cmd+Shift+P as second print shortcut (Chrome parity)
…to Window, context menu expansion - Option+Return (Alt+Enter Chrome parity) opens the address bar URL in a new tab instead of navigating current tab - contextCopyImage: fetches image bytes async, writes NSImage to NSPasteboard (copies actual image, not URL) - contextOpenLinkIncognito: opens link in a fresh private window - Context menu now has: Copy Image + Copy Image Address + Save Image As; Open Link in Incognito Window alongside New Tab / New Window
…te window (Cmd+Shift+N)
… WebKit data on history clear
…places static SF symbol)
…ol handler passthrough)
… autosave - BBDownloadPanel: show active-download count as NSDockTile badge; clear when idle - Right-click back/forward buttons → WKBackForwardList navigation dropdown (Chrome UX) - Session autosave every 30 s so tab restore survives crashes (not just graceful closes)
…ick opens new window
- BBPasswordStore wraps macOS Keychain (kSecClassGenericPassword,
service="BearBrowser-login:<host>", account=username, data=password).
Listing skips fetching passwords to avoid bulk auth prompts.
- Autofill user script injected into every main frame (forMainFrameOnly=YES):
walks each input[type=password] up to its <form>, treats the nearest prior
text/email/tel/username input as the username field. On submit, posts
{host,user,pass} to native via the "loginform" message handler. On
DOMContentLoaded posts {host} as a "lookup" so native can offer to fill.
- Native handler:
save → de-dupe against existing entries, then prompt
"Save / Never for this site / Not now"; Keychain write on Save,
BBLoginNever_<host> default on Never.
lookup → if exactly 1 entry, silent auto-fill; if >1, prompt with the
usernames; private tabs are hands-off.
- fillCredential dispatches user/pass via window.__bbAutofill and fires
input + change events so React/Vue-bound forms see the change.
- Settings → "Manage Saved Passwords…" opens a sheet listing (host, user)
with a Remove button (passwords aren't fetched in the list view —
Keychain Access shows actual values).
…untry/org) - BBProfileStore: single profile in NSUserDefaults (BBProfile_v1); PII but non-secret, so plain user defaults (Keychain reserved for passwords). - Autofill JS now classifies inputs via autocomplete attribute first (street-address, address-line1/level1/level2, postal-code, tel, email, country, organization) then falls back to name/id/placeholder regex heuristics; respects existing values (won't overwrite typed data). - DOMContentLoaded → "profileLookup"; native silently fires __bbApplyProfile with the stored dict so behaviour matches Chrome (no prompt unless empty). - Settings → "Edit Address Profile…" with 9 labelled fields, Save/Cancel.
…, manager column - BBBookmark gains an optional folder string; bookmarks.json round-trips it. - BBBookmarksStore: folders/, setFolder:forURL:, addTitle:url:folder: - Bookmarks bar renders folder buttons (SF folder icon) before root bookmarks; click → popup menu listing the folder's items. Overflow chevron menu also carries hidden folders as submenus. - Add Bookmark dialog: name + folder NSComboBox (autocomplete from existing). - Bookmark Manager: new Folder column + "Move to Folder…" button (combo box).
…oreign-lang pages - didFinishNavigation reads <html lang>; if not in user's preferred languages (NSLocale.preferredLanguages or BBTranslateNativeLangs default), sheet asks "Translate / Never for this site / Not now". Per-host opt-out persists. - translatePage: opens BBTranslateURL (default Google Translate web) with the page URL pre-filled, in a new foregrounded tab. Format takes two args: %1$@ = target language, %2$@ = URL-escaped source URL — swap to DeepL etc. by changing BBTranslateURL in defaults. - Menu item disabled on internal pages (start page, etc.).
… manager) - BBReadingList persists at readinglist.json (title/url/addedAt/read). - "Add to Reading List" via Bookmarks menu, page-context menu, and ⌘⌥D. - "Show Reading List…" opens a sheet with Read column (filled circle), title, url, plus Open/Mark Read/Remove buttons. Opening an item also marks it read.
…ter, remove-all) - Settings → "Manage Site Data & Cookies…" opens an async-loaded sheet of all WKWebsiteDataRecords (cookies + local storage + indexedDB + disk cache + service workers), sorted by domain, filterable, with per-row remove and "Remove All…" with confirm. Backed by WKWebsiteDataStore APIs only.
- BBTabItemDelegate gains hover enter/exit; BBTabItemView posts on mouse track. - BBDelegate schedules a 0.45s timer; on fire, takeSnapshotWithConfiguration at 280px wide, then shows an NSPanel (HUDWindow visual-effect, rounded, shadowed, ignoresMouseEvents) anchored just below the tab. - Cancelled on hover exit, on timer reuse, on window close. Active tab skipped (already on screen). Compiles without new frameworks (WebKit + AppKit only).
…n persistence - BBTab gains groupName + groupColorIdx (0..7 palette). - BBTabItemView paints a 3px coloured bar at the bottom edge when grouped. - Tab right-click → Group submenu: existing-group checkmark list, "New Group…" (alert prompt), "Remove from Group", "Close <name> Group" (tears down every non-pinned tab in that group, honours the active-tab fallback). - Auto-color assignment: matches an existing group's slot when joining; else picks the lowest unused slot. - Session restore round-trips group + groupColor.
…-to-open-tab - Calculator chip (∑): pure-arithmetic input is evaluated via NSExpression and shown at the top of the dropdown; selecting it copies the answer instead of navigating. Grammar restricted so URLs aren't mistaken for expressions. - Keyword shortcuts (⌕): "wiki foo", "yt foo", "gh foo", "ddg/kagi/g foo", "so/mdn/npm/hn/amzn/map foo" route to the matching site search. - "Switch to this tab" (⇄): when a typed query matches an open tab's title or URL, surface a row at the top that jumps to that tab instead of navigating. Snapshot rebuilt on every keystroke; active tab excluded.
…print sel,
drag URL out, dock menu, native spellcheck on edit focus)
- Security info sheet now lists granted media perms for the current host and
gains a "Reset Site Permissions" button.
- Image right-click: Search on Google Lens / TinEye (URL-by-search routes).
- ⌘⇧P: Print Selection — pulls the page selection's HTML into a hidden
WKWebView and runs the standard print operation; empty selection falls back
to printing the whole page.
- BBAddressField intercepts mouseDown when unfocused and starts a drag carrying
the current URL (NSPasteboardTypeURL + String) — drop into another app /
Finder / bookmarks bar.
- Application Dock menu: New Tab / New Window / Incognito + Recently Closed
submenu with the last 10 entries.
- Autofill JS reports document.activeElement editable focus; the right-click
monitor defers to the native WKWebView menu in that case so native spell-
check ("Add to Dictionary", suggestions) stays reachable.
… submenu,
drag downloads to Finder, drop URLs onto bookmarks bar
- Edit ▸ Find ▸ Use Selection for Find (⌘E): pulls window.getSelection(),
populates the find bar, runs findNext.
- ⌥⌘← / ⌥⌘→ — Chrome macOS aliases for prev/next tab (in addition to ⌃⇥).
- History ▸ Recent Pages: NSMenuDelegate populates last 10 unique-by-URL
history entries on open; click navigates.
- BBDownloadRowView (NSView subclass) — drag a completed download from the
panel to Finder/Mail/another app; carries the file URL with workspace icon.
- BBBookmarksBarView accepts NSPasteboardTypeURL/String drops; dropped URLs
become root-folder bookmarks (de-duped) and the bar reloads immediately.
…l Page - didStartProvisionalNavigation closes the find bar and clears find state so stale matches from the previous page don't carry over. - Selection context menu: "Speak Selection" (AVSpeechSynthesizer), "Email Selection…" (mailto: with page URL footer). - Page context menu: "Email Link to Page…" (mailto: with title + URL).
- F5 → Reload, F11 → Toggle Full Screen, F12 → Developer Tools (Chrome/Win
parity, in addition to existing ⌘R / ⌃⌘F / ⌥⌘I).
- Right-click / control-click a bookmark in the bar:
Open in New Tab (background) / Open in New Window
Copy Link / Move to Folder…
Delete
NSButton.menu is built per-bookmark eagerly so the system's contextual
trigger surfaces it without an event monitor.
…ed workspaces - Find bar gains an "Aa" toggle button. WKFindConfiguration.caseSensitive and the match-count JS both respect the state; flipping it re-runs the search. - Tab context menu: "Mute Site" / "Unmute Site" persists in BBMuteSite_<host>; toggling applies to all tabs on the host now AND on future navigation (didFinishNavigation re-applies). - Page context menu: "Copy Page Title" — full page title to clipboard. - Bookmarks menu: "Save Tabs as Workspace…" saves current tabs as a named set in BBWorkspaces; "Open Workspace" submenu reopens the set into new tabs; "Delete Workspace…" nested submenu removes one.
…+password toasts
- newTab: now focuses the address bar and selects text (Chrome parity — you
can type a URL/query immediately after ⌘T).
- showToast: brief in-window notification bottom-right, animated in/out,
ignores mouse events. No entitlements / no UserNotifications framework.
- Wired into downloadDidFinish ("Downloaded <name>") and password save
("Password saved to Keychain").
…bookmark, reader font - Bookmark Manager: search field filters title/URL/folder live; open/remove/move operate on the filtered set. Remove now works via URL, not index. - History window: "Delete Entry" button removes all visits of a URL both from memory and the on-disk jsonl (BBHistoryStore.removeAllForURL rewrites the log). - URL bar zoom chip: shows current page-zoom % when != 100 (right side, before the star); click resets to 100. Updated on setZoom + applyZoomForCurrentTab. - Middle-click a bookmark on the bookmarks bar → opens it in a new background tab (piggy-backs the existing middle-click monitor before the webview probe). - Reader mode gains a floating A− / Aa / A+ button strip (top-right, blurred glass); persists user-preferred size via BBReaderFontSize default (14–28px).
…ession-restore pref - Bookmarks menu: Import Bookmarks (HTML)… + Export Bookmarks (HTML)… Netscape Bookmark File Format; folders round-trip. Import is <A>+<H3> regex parse tolerant of Chrome/Firefox/Safari export variants; de-dupes by URL. - Right-click empty tab-bar area (or the "+" button): "New Tab / Reopen Closed / Recently Closed submenu / Bookmark All Tabs / Save as Workspace". - Settings gains "Restore last session on launch" (default ON). Off: session restore is skipped and BearBrowser opens with just the start page.
…pen-all,
reading list export, Chrome + Safari bookmark import
- BBDelegate exposes a host-keyed NSCache favicon cache; bookmark bar renders
cached favicons (14×14, lazy-fetched from /favicon.ico) with letter fallback
built into the button title.
- Bookmark folder buttons gain a right-click menu: Open All in New Tabs,
Rename Folder…, Delete Folder (removes contained bookmarks), Unfile Folder
(sends contents to root).
- BBBookmarksStore: renameFolder:to: and removeFolderAndBookmarks:.
- Reading list sheet: "Export…" writes a styled HTML list with read state
visualised (strikethrough).
- Bookmarks menu: "Import from Chrome" reads ~/Library/Application Support/
Google/Chrome/Default/Bookmarks JSON; "Import from Safari" reads
~/Library/Safari/Bookmarks.plist (TCC-gated; falls back to a toast telling
the user to HTML-export from Safari). Both flatten to one folder level.
…kmark sort - Page context menu: Copy Page as Markdown Link → clipboard "[Title](URL)". - New Tab Page: shows the 6 most recent unread reading-list items in a card below the shortcut grid, styled to match. Injected only when there is actually anything unread. - Bookmark Manager sort dropdown: Custom / Title A→Z / Newest first; persists the reorder to the store and refreshes the bar.
…me button, password CSV - History menu adds Cmd+← / Cmd+→ aliases for Back/Forward. - Tab menu adds Ctrl+PgUp / Ctrl+PgDn as prev/next tab (Chrome/Win parity). - Address bar keyword shortcuts also accept a leading "!" (DuckDuckGo-style bangs) — "!wiki foo" == "wiki foo". - Toolbar gains a Home button (SF "house.fill"), shown only when Settings has a Homepage. Toggling the Settings field flips visibility across every open window immediately. - Settings ▸ Manage Saved Passwords sheet gains Import CSV / Export CSV (Chrome/Firefox column layout — url/username/password, plus tolerant of login_uri/origin variants). Export confirms first and warns the file is unencrypted; import saves each row to Keychain via saveHost:username:password:.
…nu, NTP tile hide, home menu - Password generator sheet: new "Passphrase Instead" toggle produces a hyphenated 5-word passphrase from a 200-word EFF-style list (~52 bits); BBGenPassphrase default remembers the preference. Sheet also shows Weak/Fair/Strong/Excellent based on charset+length entropy estimate. - Download panel rows gain a right-click menu: Copy Source URL / Show in Finder / Open / Remove from List / Delete File (moves to Trash + removes). BBDownloadItem gains sourceURL (captured at start via response.URL / originalRequest.URL). - New Tab Page shortcut tiles get a hover × button; clicking hides the tile and posts a "ntpHide" message that appends the host to BBHiddenTopSites, so topSitesLimit: skips it thereafter. - Home button gains a right-click menu: Go Home / Set Current Page as Home (writes BBHomepage and unhides the button across windows) / Change Homepage in Settings…
…ab URLs - Downloads panel gets a "Clear" button that keeps only in-progress items. - Settings ▸ New Tab Page ▸ "Unhide Removed Shortcuts…" wipes BBHiddenTopSites (lists what's currently hidden first). - Toolbar reader-mode book icon appears when the current page has an <article>/<main>/[role=main] with ≥600 chars of paragraph text; clicking toggles reader mode. - Tab menu: "Copy URLs of All Tabs" newline-joins non-internal tab URLs to the clipboard.
- Cmd+Shift+O alias for Bookmark Manager (Chrome/macOS parity, in addition to the existing Cmd+Opt+B). - File ▸ Save Page as PDF… (Cmd+Opt+S) uses WKWebView.createPDFWithConfiguration: to write a real PDF of the current page. Distinct from print → PDF because it skips the print dialog and produces a single-page-per-visible-region document.
…s auto-clear - File ▸ Take Page Screenshot… (⌃⌘S) uses WKWebView.takeSnapshotWithConfiguration: at 2x for retina; writes a PNG of the current viewport. - App menu gains "Restart BearBrowser" — relaunches via `/usr/bin/open -n` then terminates the current instance after a short delay. - Manage Saved Passwords sheet gets a "Copy Password" button next to Remove (fetches from Keychain per-row so no bulk auth prompt) and auto-clears the clipboard 30 s later — only if the value is still ours.
…RL dropdown,
Reset All Preferences in Settings
- Right-click empty area on the bookmarks bar → Add Current Page… /
Bookmark All Tabs… / New Folder… / Hide Bookmarks Bar / Show Bookmark Manager.
bmBarNewFolder: creates the folder by inserting a placeholder bookmark
under bearbrowser://folder-placeholder/<name> (kept out of the bar's
root by the folder grouping).
- Address bar dropdown now also matches unread Reading List items (📖 badge)
right after the "Switch to tab" and Bookmark rows. Global-ish search across
tabs + bookmarks + reading list + history + search from one field.
- Settings ▸ Reset ▸ "Reset All Preferences…" strips every BB-prefixed
NSUserDefaults key with confirm; explicitly does NOT touch bookmarks,
history, or Keychain passwords.
…pen-all,
Cmd/Shift-click bookmark bar items
- Reload button gains a right-click menu: Normal Reload / Hard Reload
(bypass cache) / Empty Cache and Hard Reload (wipes the host's cookies +
cache + IndexedDB + service workers via WKWebsiteDataStore, then reloads).
- Star button gains a right-click menu: Bookmark This Page / Edit Bookmark…
Edit modal has name / URL / folder combo box and persists directly to the
store; falls back to Add Bookmark flow when the current URL isn't bookmarked.
- Middle-click a folder button on the bookmarks bar → opens every bookmark
in that folder in background tabs (skips placeholder rows for empty folders).
- Bookmark bar items now honour link-modifier click parity:
⌘-click → new background tab
⌘⇧-click → new tab + foreground
⇧-click → new window
⌃-click → context menu (existing)
mdheller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the crash from the latest report plus tab/history/menu issues, then grows into a broad Chrome-UX creature-comfort push on the macOS WKWebView shell. All in
native/macos/BearBrowserWebKitLauncher.m(+native/macos/BearBrowser-start.html). Every commit compiles clean;BearBrowser.appbuilds viascripts/bearbrowser-build-native-shell.shand installs to/Applications/BearBrowser.app.Original fixes (rounds 0–2)
Crash (EXC_BAD_ACCESS in
objc_retain) —self.windowwas astrongproperty butNSWindowdefaultedreleasedWhenClosed=YES→ dangling pointer → never-removed address-dropdown monitor touched it on the next event. Fix:releasedWhenClosed=NO,removeMonitor:on close, weak-captureselfin the monitor block.Multi-window dead-on-arrival —
newWindow:controllers were deallocated immediately becauseNSApplication/NSWindowdelegates areweak. Now retained for the window's lifetime via a global controller set.Tabs with many open — Safari-style compress-to-fit; tabs shrink to favicon-only compact mode with close-on-hover + full-title tooltip; + button pinned to the right edge.
History — title recorded post-KVO so late-arriving titles land; dedupe-by-URL in the panel; SPA
pushState/replaceState/popstaterecorded via injected hook +historynavhandler; Clear Browsing Data.Menus — rebuilt to mirror Chrome on macOS: Chrome · File · Edit · View · History · Bookmarks · Tab · Window · Help, with Find/Developer submenus.
Chrome-UX creature comforts (rounds 3–19)
Keyboard shortcuts — full parity: ⌘L/T/W/R/⇧R/./F/G/Y/J/E/O(⇧)/0/+/−/1–9/⇥/⇧⇥/[ /] /K, ⌘⇧C/T/W/N/A/⌫/P/O, ⌥⌘I/S/D, ⌃⌘F/R/U/S, ⌘←/→, ⌘⌥←/→, ⌃PgUp/PgDn, F5/F11/F12, cheat sheet at ⌘/.
Tabs — drag-reorder, pin, mute (session + persistent per-site), suspend, duplicate, move-to-window, search (⌘⇧A), audio indicator, loading spinner, hover thumbnails, tab groups (named + coloured), URL drop-target, right-click modifier parity.
Address bar — inline calculator (
2+3*4→ chip → clipboard on select), keyword shortcuts +!bang syntax (!wiki foo), Switch-to-open-tab row, Reading-List rows, dropdown ordering unchanged so power-user muscle memory holds. HTTPS-only upgrade, drag URL out to Finder/Mail. Zoom-% chip. Home button (visible when homepage set) with Set Current Page as Home / Go / Change… menu. Star button gains Edit Bookmark modal.Bookmarks — one-level folders, bar favicons (host-keyed NSCache), overflow chevron, drag-drop URL onto bar to save, right-click bar items (Open in tab/window/incognito, Copy Link, Move to Folder, Delete), right-click empty area (Add Current Page, Bookmark All Tabs, New Folder), right-click folder (Open All, Rename, Delete, Unfile), middle-click folder = open all in bg tabs, Cmd/Shift-click bar items = link-modifier parity, sort (custom / A→Z / newest), Bookmark Manager search field, HTML import/export, Chrome + Safari native import (JSON/plist parse; TCC-gated Safari falls back to a helpful toast).
Autofill + passwords — Keychain login save+fill on submit; private tabs hands-off; per-site "Never" opt-out. Password generator (random 20-char via
SecRandomCopyBytes, or Diceware-style 5-word passphrase from 200-word list); entropy meter labels Weak/Fair/Strong/Excellent. CSV import/export (Chrome/Firefox column layout). Manage Saved Passwords sheet: Copy Password w/ 30-s auto-clear (only if clipboard still ours). Address autofill (name/email/phone/street/city/region/postal/country/org) with autocomplete-attr + regex heuristics.Downloads — panel with dock badge, custom folder (Settings), per-row context menu (Copy Source URL / Show / Open / Remove / Delete-to-Trash), drag-out to Finder as file, Clear Finished button, toast on complete.
Rendering — reader mode with A− / Aa / A+ chip (
BBReaderFontSizepersists), toolbar reader button appears on article-like pages, HTML5 Fullscreen API enabled, per-site zoom (persisted per host) + pinch + Ctrl+scroll.Session & translation — crash-safe autosave every 30 s, restore-on-launch preference, tab-group state round-trips, foreign-language translate offer (
<html lang>sniff, per-host opt-out), configurable translator URL (BBTranslateURL), Saved Workspaces (name a tab set, reopen as batch, delete via nested submenu), Reading List with HTML export.Privacy/data — Site Data manager (all
WKWebsiteDataRecordtypes, filter, per-record delete, remove-all), site permissions block in the security-info sheet with Reset Site Permissions, HTTPS-only upgrade, private-tab window title prefix, tracking-param strip, "Empty Cache and Hard Reload" (per-host wipe + reload).System polish — App Dock menu (New Tab / New Window / New Incognito / Recently Closed), Restart menu item, in-window toasts (download / password saved), Recent Pages menu (last 10 unique, dedupe-by-URL), keyboard-shortcut cheat sheet (⌘/), Report an Issue, drag URL out of address field, Cmd+click bookmark bar item = background tab, Reset All Preferences (BB-prefixed defaults only; preserves bookmarks / history / Keychain).
NTP — real favicons on top-sites tiles with letter fallback, hover × to hide (persistent), 6-item unread reading-list card, Settings ▸ Unhide Removed Shortcuts.
Scope contained
Every commit in this PR touches only:
native/macos/BearBrowserWebKitLauncher.mnative/macos/BearBrowser-start.htmlNo other file in the repo is modified. If a reviewer wants to bisect,
git log --onelinereads round-by-round.What's still open (not in this PR)
These are all cert- or scope-gated for a follow-up.
🤖 Generated with Claude Code